Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove npm audit fallback request #900

Closed
Tracked by #898
wraithgar opened this issue Sep 25, 2024 · 0 comments · Fixed by npm/cli#7911
Closed
Tracked by #898

Remove npm audit fallback request #900

wraithgar opened this issue Sep 25, 2024 · 0 comments · Fixed by npm/cli#7911

Comments

@wraithgar
Copy link
Member

When the new audit endpoint was added, in order for the cli to ship it without having to wait for a new semver major it was done with a fallback to the old endpoint:

https://github.com/npm/cli/blob/63d6a732c3c0e9c19fd4d147eaa5cc27c29b168d/workspaces/arborist/lib/audit-report.js#L332-L345

As far as we can tell, nobody has implemented an audit endpoint that relies on the old URL, and the new one works just fine on the npm registry.

This code should be removed in a semver-major release of npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant