Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release-please rebuild PR for chore commits #378

Closed
lukekarrys opened this issue Nov 16, 2023 · 2 comments · Fixed by #380
Closed

Make release-please rebuild PR for chore commits #378

lukekarrys opened this issue Nov 16, 2023 · 2 comments · Fixed by #380

Comments

@lukekarrys
Copy link
Contributor

Problem statement: release-please will only rebuild a release PR when the body of the PR changes.

Current solution: run a workflow that forces the PR to be rebuilt by changing the PR body.

Problems with current solution: Requires manual work.

New proposed solution: We append Last commit: $SHA to the bottom of every PR body (and therefore changelog). This will have the effect of rebuilding the PR for every commit without including changelog entries for chore commits. (edited)

@wraithgar
Copy link
Member

We should stop omitting chore from the changelog, and put it in a <details> block so it doesn't take up real estate by default. We can continue using chore for now but will also add a scope to our chore commits so we can start to see if we eventually want a new section (like build or tests).

@wraithgar
Copy link
Member

Current hard problem: Naming the changelog header for this section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants