This repository has been archived by the owner on Jul 28, 2021. It is now read-only.
make fs operations optimistic #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the fs functions to try the normal impl first before calling pkglock.resolve.
zkat
approved these changes
Nov 11, 2018
|
YOU DID FIX IT. THANK YOU! #nailedit |
|
I hope I didn't do too much damage 😉 |
|
oh nice! |
|
omg this fixed one thing while breaking another. For some reason, I've started getting EEXIST errors when trying to initial-load a dep (from an empty cache). I don't know which of the changes is causing this but I guess I'll have to comb through them one-by-one. Really about time we have unit tests for this. sigh. |
|
I managed to fix a few other bits too, at least. |
zkat
pushed a commit
that referenced
this pull request
Nov 11, 2018
This changes the fs functions to try the normal impl first before calling pkglock.resolve.
|
sorry about that. I wasn't sure how to test it |
|
I found the bugs! Everything is good now. I'll stub out some tests soon so folks can help with testing this 👍 |
|
+1 for unit tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the fs functions to try the normal impl first before calling pkglock.resolve.
It looks like you went ahead and did some of these already over the last few days- I didn't know you wanted them done sooner than the weekend or I wouldn't have volunteered to do them, sorry to keep you waiting.
The merge conflicts may not have been resolved properly because of that; I've checked Allow edits from maintainers so please do whatever you feel makes the most sense.