feat(view): add 'view' command #27
Conversation
Move to use JSX and use register command.
Allow unlimited items when field is specified.
Add packument info to outputted JSON, as is custom in `npm view`. It's a bit double if multiple versions are queried, but that's just how it is. Also allows packument-specific props to be queried.
Allow dots (.) in props with a special prop syntax:
Data:
{ foo: {
'bar.baz': 1,
bar: { baz: 2 }
} }
Query:
foo[bar.baz] // -> 1
Useful to query versions, deps:
time[0.10.1]
dependencies[lodash.uniq]
Show dependencies in columns, matching the old behaviour.
| @@ -0,0 +1,51 @@ | |||
| 'use strict' | |||
|
|
|||
| const npmlog = require('npmlog') | |||
There was a problem hiding this comment.
I'm pretty sure you could use libnpm.log.
| ) | ||
|
|
||
| if (!props && items.length > maxItems) { | ||
| items = items.slice(0, --maxItems).concat( |
There was a problem hiding this comment.
Why are you decrementing maxItems here?
There was a problem hiding this comment.
That should probably be done more explicitly, but basically: if the max amount of rows is 6, there should be 5 items and one line explaining there are more. I could also have increased the maxItems check by one, but both are wrong, and I found this one more practical, as maxItems now always limits the rows.
There was a problem hiding this comment.
Is there a reason you use --maxItems and not maxItems - 1?
There was a problem hiding this comment.
Because it's referenced once more (again, not should have done that more explicitly).
| builder (yargs) { | ||
| return yargs.help().alias('help', 'h').options(View.options) | ||
| }, | ||
| options: Object.assign(require('../common-opts'), {}), |
There was a problem hiding this comment.
Wouldn't it make more sense if these arguments were reversed?
There was a problem hiding this comment.
Yep, don't know why I did it that way... Not that it matters, at the moment.
|
Whoops started that earlier today. |
|
@legodude17 No problem, there might be a refactor (to use Ink 2) coming either way, so feedback is appreciated. |
As seen in https://npm.community/t/3088.