This repository has been archived by the owner on Jul 28, 2021. It is now read-only.
fix(sh): fix node->tish rewrites #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalton
reviewed
Mar 6, 2019
| @@ -391,7 +391,7 @@ class Installer { | |||
| this.log('verbose', 'tinkifyBins', 'convering installed bins to use tink:', bins) | |||
| return BB.map(bins, async bin => { | |||
| const real = await realpathAsync(bin) | |||
| const data = (await readFileAsync(real, 'utf8')).replace(/(#!\s*.*\s*)node/g, '$1tish') | |||
| const data = (await readFileAsync(real, 'utf8')).replace(/^(#!.*\b)node([^-\w]|$)/g, '$1tish$2') | |||
| await writeFileAsync(real, data, 'utf8') | |||
| }, { concurrency: 50, Promise: BB }) | |||
There was a problem hiding this comment.
It's a script that shorthands tink sh, since you can't have arguments in some key places (like shebangs in some platforms). Also just a useful shorthand for it.
zkat
approved these changes
Mar 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the node->tish rewrites a little less aggresive
Fixes #5909