Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid password when password is empty on Windows #6

Open
jsanko9 opened this issue Mar 1, 2018 · 2 comments
Open

Invalid password when password is empty on Windows #6

jsanko9 opened this issue Mar 1, 2018 · 2 comments

Comments

@jsanko9
Copy link

jsanko9 commented Mar 1, 2018

Hello,
I had a problem with blank password.
First, you need to set double quotation marks so you don't get invalid password message.
This may not be huge, but accepting blank string would be preferred.

Secondly, On Windows I believe there is problem with quotation marks.

I have resolved this by passing another argument to spawn command:
{windowsVerbatimArguments: true}

This was based on this discussion
nodejs/node#5060 (comment)

In your case you would need to replace following:
107: child = spawn(args[0], args.slice(1));
with
107: child = spawn(args[0], args.slice(1),{windowsVerbatimArguments: true});

Thank you for your work.

@dimlucas
Copy link

I managed to overcome this issue by forking the project and removing the check for missing password on line 8 in index.js

As a suggestion, I believe a skipPassword flag would be more appropriate

@nrhirani
Copy link
Owner

nrhirani commented Apr 1, 2019

@dimlucas / @jsanko9 Would like to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants