Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh projects view clears cache #1058

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Apr 1, 2021

What it does

Clicking the refresh icon in the Projects view will delete the cache for the current workspace file.

This PR also adds a mechanism to watch the workspace file and automatically refresh the projects view.

Closes #1042

@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2021

Nx Cloud Report

CI ran the following commands for commit 3bc0f95. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --all --parallel --target=build
#000000 nx run-many --all --parallel --target=lint
#000000 nx run-many --all --parallel --target=test

Sent with 💌 from NxCloud.

@@ -11,6 +11,7 @@
"request": "launch",
"runtimeExecutable": "${execPath}",
"args": [
"--disable-extensions",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this here so that we just get errors related to our extension 😅

@Cammisuli Cammisuli force-pushed the refresh-projects-view branch from 0c8c041 to 3bc0f95 Compare April 1, 2021 15:32
Comment on lines +80 to +83
{
"command": "nx.generate.ui.fileexplorer",
"when": "false"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but I hid this command from the command palette as it doesn't make sense there.

@Cammisuli Cammisuli requested a review from sandikbarr April 1, 2021 15:59
Copy link
Contributor

@sandikbarr sandikbarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great for me. Thanks for fixing this.

@Cammisuli Cammisuli merged commit 4741999 into nrwl:master Apr 1, 2021
@Cammisuli Cammisuli deleted the refresh-projects-view branch April 1, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing workspace/angular.json does not update projects
2 participants