fix: strip appsDir and libsDir from path if app|application or lib|library #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit e534139. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
sandikbarr
commented
Jun 11, 2021
| .replace(/\\/g, '/') | ||
| .replace(/^\//, ''); | ||
|
|
||
| const nxConfig = readAndCacheJsonFile('nx.json', workspacePath); |
There was a problem hiding this comment.
I tried this with workspaceLayout() using a deep import from nx/workspace, but it wasn't giving me the configured path with a workspace I was testing on for some reason.
sandikbarr
commented
Jun 11, 2021
| return { | ||
| path, | ||
| directory: path, | ||
| project: projectName, | ||
| projectName, |
There was a problem hiding this comment.
I also slipped in support for setting the projectName schema option. Some of our generators use projectName rather than project.
…menu instead of path/directory and project; otherwise, if no project option, set pathdirectory
Cammisuli
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't seem to figure out how we could determine if a schematic/generator is a project and what the projectType is from the schema before it is generated, and I am not totally happy with this
schematic.name === 'application' || schematic.name === 'app'andschematic.name === 'library' || schematic.name === 'lib'solution.Update: added a commit that only sets project/projectName or path/directory from the explorer context menu, not both. Project takes precedence.