feat(nx-plugin): thread jest options through nx-plugin:e2e executor #11442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
nx-plugin:e2e
executor doesn't expose any of the underlyingjest
CLI options, making it hard to use, and in some cases incorrect.E.g. Since E2E tests for generators in plugins operate on a single expected E2E directory (
tmp/nx-e2e/proj
), there is some potential for conflict due to Jest's default parallelism in tests if two tests are messing with that directory simultaneously using functions likeensureNxProject
. I'd like to be able to try the--runInBand
option to see if it resolves what I'm seeing, but am unable to do so because thee2e
executor hides this arguments.Unsure if this is technically a feature or a bug fix as a result.
Expected Behavior
I should be able to pass any typical
jest
CLI option down to thee2e
executor and expect it to pass them down to the underlyingjest
process.Related Issue(s)
I didn't open an issue for this. Just decided to directly PR.