fix(nextjs): fix .next folder linting #11614
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4612725. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| @@ -36,6 +36,11 @@ export async function addLinting( | |||
| // Turn off @next/next/no-html-link-for-pages since there is an issue with nextjs throwing linting errors | |||
| // TODO(nicholas): remove after Vercel updates nextjs linter to only lint ["*.ts", "*.tsx", "*.js", "*.jsx"] | |||
|
|
|||
| reactEslintJson.ignorePatterns = [ | |||
There was a problem hiding this comment.
Could this go into a .eslintignore file at the root?
There was a problem hiding this comment.
I don't think so since next uses the react .eslintignore.
I think the pattern .next/ is project specific, so probably not.
There was a problem hiding this comment.
I think since .eslintignore isn't always present ,we can keep this just in the app's ignore folder.
ndcunningham
force-pushed
the
fix/next-linting
branch
from
d195b0a
to
fc1c8d9
Compare
ndcunningham
force-pushed
the
fix/next-linting
branch
from
fc1c8d9
to
a2fe718
Compare
| if (project.targets?.build?.executor !== '@nrwl/next:build') return; | ||
|
|
||
| const eslintPath = `${project.root}/.eslintrc.json`; | ||
| debugger; |
ndcunningham
force-pushed
the
fix/next-linting
branch
2 times, most recently
from
68dfe41
to
766af6d
Compare
| let tree: Tree; | ||
|
|
||
| beforeEach(async () => { | ||
| tree = createTreeWithEmptyV1Workspace(); |
There was a problem hiding this comment.
I think we want to use createTreeWithEmptyWorkspace here, and updateProjectConfiguration so it's more future-proof.
ISSUES CLOSED: nrwl#11541
ndcunningham
force-pushed
the
fix/next-linting
branch
from
766af6d
to
4612725
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
ISSUES CLOSED: #11541
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #