There is a new Jest memory leak after updating to v7.7 #1217
Assignees
Labels
outdated
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
type: bug
Comments
|
@nrwl/nx v7.7 includes a new version of
So it would be nice if there is an option added in nx to disable the diagnostics in But anyway, if your app gets bigger at some you will reach the default memory limit in node.js (~1.5 GB). We already have that problem. As suggested in the @angular/cli repo we manually increase the memory limit for all test and build runs.
|
|
I'm aware that we will need more memory at some point but before the update, ~500mb was enough. More memory being needed or even tests being slower is not really a problem. The problem is that no memory is being freed between test suites as you can see in my log. I'll create a patch to disable diagnostics in |
|
I've created a patch to disable This is the patch: diff --git a/node_modules/@nrwl/builders/src/jest/jest.builder.js b/node_modules/@nrwl/builders/src/jest/jest.builder.js
index b87e9e5..434d3ed 100755
--- a/node_modules/@nrwl/builders/src/jest/jest.builder.js
+++ b/node_modules/@nrwl/builders/src/jest/jest.builder.js
@@ -14,6 +14,7 @@ var JestBuilder = /** @class */ (function () {
JestBuilder.prototype.run = function (builderConfig) {
var options = builderConfig.options;
var tsJestConfig = {
+ diagnostics: false,
tsConfig: path.join('<rootDir>', path.relative(builderConfig.root, options.tsConfig))
};
// TODO: This is hacky, We should probably just configure it in the user's workspace
@@ -29,6 +30,8 @@ var JestBuilder = /** @class */ (function () {
}
catch (e) { }
var config = {
+ detectOpenHandles: true,
+ logHeapUsage: true,
watch: options.watch,
coverage: options.codeCoverage,
bail: options.bail,This is the new log: |
|
Great debugging! Can you reproduce with a more minmal project? It seems the way With my test project, I see this: which may have a more minor memory leak? LOGS
|
|
@FrozenPandaz it works fine locally actually. My logs are from GitLab runners. I'm a bit short of time right now, but I'll see if I can come up with some repo. ): |
|
Hi, I have the same error, but I'm running my test suite on TravisCI, here is the repo I'm working on: https://github.com/llstarscreamll/angular-kirby I have tried many things to fix the error, but nothing works... some links: jestjs/jest#7647 Here is the logs from my failed builds: https://github.com/llstarscreamll/angular-kirby On my local machine all the tests are green. |
|
Hi every one, my build is now passing!! I upgrade some dependencies and change TravisCI setup to this: language: node_js
node_js: 12
dist: trusty
sudo: required
cache:
npm: false
install:
- yarn install --network-timeout 1000000
notifications:
email: true
branches:
except:
- /^v\d+\.\d+\.\d+$/
script: ng test -i --ci --bail=1 --pass-with-no-tests |
|
@llstarscreamll what dependencies did you upgrade to make the build pass? |
|
Here is the diffs from the dependencies changes, including the TravisCI setup: |
|
Just confirming. It looks like the issue has been fixed in 8.5. Right? |
vsavkin
added
scope: testing tools
|
Closing this issue due to inactivity. If the problem persists, please reopen the issue. Thank you. |
|
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Expected Behavior
My test suite runs without memory leaks.
Current Behavior
My test suite leaks between 50 and 100mb between each lib/app run.
Failure Information
I'm guessing there's a bug somewhere, but can't say for sure where. I've tried to exclude Jest itself from the equation because the memory leak seems to happen between suites and not within a suite.
Steps to Reproduce
All I did was update to @nrwl/nx v7.7 and all related dependencies as usual. It wasn't leaking in v7.6.
So I guess if anyone has a repo using Jest unit tests, that's all that is needed.
Context
Please provide any relevant information about your setup:
{ "@angular-devkit/build-angular": "0.13.7", "@angular/animations": "7.2.11", "@angular/cdk": "7.3.6", "@angular/cli": "7.3.7", "@angular/common": "7.2.11", "@angular/compiler-cli": "7.2.11", "@angular/compiler": "7.2.11", "@angular/core": "7.2.11", "@angular/flex-layout": "7.0.0-beta.24", "@angular/forms": "7.2.11", "@angular/http": "7.2.11", "@angular/language-service": "7.2.11", "@angular/material": "7.3.6", "@angular/platform-browser-dynamic": "7.2.11", "@angular/platform-browser": "7.2.11", "@angular/platform-server": "7.2.11", "@angular/router": "7.2.11", "@ng-toolkit/serverless": "1.1.51", "@ng-toolkit/universal": "1.1.51", "@nguniversal/common": "7.1.1", "@nguniversal/express-engine": "7.1.1", "@nguniversal/module-map-ngfactory-loader": "7.1.1", "@ngx-formly/core": "4.8.3", "@ngx-formly/material": "4.8.3", "@nrwl/builders": "7.6.0", "@nrwl/nx": "7.6.0", "@nrwl/schematics": "7.6.0", "angular2-text-mask": "9.0.0", "apollo-angular-link-http": "1.5.0", "apollo-angular": "1.5.0", "apollo-cache-inmemory": "1.5.1", "apollo-client": "2.5.1", "apollo-link-context": "1.0.17", "apollo-link-error": "1.1.10", "apollo-link-ws": "1.0.17", "apollo-link": "1.2.11", "aws-serverless-express": "3.3.6", "codelyzer": "5.0.0", "core-js": "2.6.5", "cors": "2.8.5", "cypress": "3.2.0", "graphql-tag": "2.10.1", "graphql": "14.2.1", "hammerjs": "2.0.8", "jest-junit": "6.3.0", "jest-preset-angular": "6.0.2", "jest": "23.6.0", "ngx-custom-validators": "7.0.0", "ngx-take-until-destroy": "5.4.0", "rxjs": "6.4.0", "text-mask-addons": "3.8.0", "webpack-cli": "3.3.0", "zone.js": "0.9.0", }Failure Logs
Example run after the update:
The text was updated successfully, but these errors were encountered: