Skip to content

Commit 89eb799

Browse files
authored
Merge pull request #237 from ns1/PENG-4708/go_ask_update
Add new monitoring permissions support
2 parents a9aa040 + e316263 commit 89eb799

7 files changed

+28
-1
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 2.12.0 (Jul 19th, 2024)
2+
3+
FEATURES:
4+
5+
* Adds support for new split monitoring permissions create_jobs, update_jobs and delete_jobs
6+
17
## 2.11.0 (May 23rd, 2024)
28

39
FEATURES:

rest/account_apikey_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99

1010
"github.com/stretchr/testify/assert"
1111
"github.com/stretchr/testify/require"
12+
1213
"gopkg.in/ns1/ns1-go.v2/rest/model/account"
1314
)
1415

@@ -22,6 +23,10 @@ func TestCreateAPIKey(t *testing.T) {
2223
assert.Nil(t, k.Permissions.Security)
2324
assert.Nil(t, k.Permissions.DHCP)
2425
assert.Nil(t, k.Permissions.IPAM)
26+
assert.False(t, k.Permissions.Monitoring.ManageJobs)
27+
assert.False(t, k.Permissions.Monitoring.CreateJobs)
28+
assert.False(t, k.Permissions.Monitoring.UpdateJobs)
29+
assert.False(t, k.Permissions.Monitoring.DeleteJobs)
2530

2631
_, err = w.Write(b)
2732
require.NoError(t, err)

rest/account_team_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99

1010
"github.com/stretchr/testify/assert"
1111
"github.com/stretchr/testify/require"
12+
1213
"gopkg.in/ns1/ns1-go.v2/rest/model/account"
1314
)
1415

@@ -22,6 +23,10 @@ func TestCreateTeam(t *testing.T) {
2223
assert.Nil(t, tm.Permissions.Security)
2324
assert.Nil(t, tm.Permissions.DHCP)
2425
assert.Nil(t, tm.Permissions.IPAM)
26+
assert.False(t, tm.Permissions.Monitoring.ManageJobs)
27+
assert.False(t, tm.Permissions.Monitoring.CreateJobs)
28+
assert.False(t, tm.Permissions.Monitoring.UpdateJobs)
29+
assert.False(t, tm.Permissions.Monitoring.DeleteJobs)
2530

2631
w.Write(b)
2732
}))

rest/account_user_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99

1010
"github.com/stretchr/testify/assert"
1111
"github.com/stretchr/testify/require"
12+
1213
"gopkg.in/ns1/ns1-go.v2/rest/model/account"
1314
)
1415

@@ -22,6 +23,10 @@ func TestCreateUser(t *testing.T) {
2223
assert.Nil(t, u.Permissions.Security)
2324
assert.Nil(t, u.Permissions.DHCP)
2425
assert.Nil(t, u.Permissions.IPAM)
26+
assert.False(t, u.Permissions.Monitoring.ManageJobs)
27+
assert.False(t, u.Permissions.Monitoring.CreateJobs)
28+
assert.False(t, u.Permissions.Monitoring.UpdateJobs)
29+
assert.False(t, u.Permissions.Monitoring.DeleteJobs)
2530

2631
w.Write(b)
2732
}))

rest/client.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import (
1313
)
1414

1515
const (
16-
clientVersion = "2.11.0"
16+
clientVersion = "2.12.0"
1717

1818
defaultEndpoint = "https://api.nsone.net/v1/"
1919
defaultShouldFollowPagination = true

rest/model/account/permissions.go

+3
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ type PermissionsMonitoring struct {
5858
ManageLists bool `json:"manage_lists"`
5959
ManageJobs bool `json:"manage_jobs"`
6060
ViewJobs bool `json:"view_jobs"`
61+
CreateJobs bool `json:"create_jobs"`
62+
UpdateJobs bool `json:"update_jobs"`
63+
DeleteJobs bool `json:"delete_jobs"`
6164
}
6265

6366
// PermissionsDHCP wraps a User's "permissions.dhcp" attribute for DDI.

rest/model/account/user_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,9 @@ func TestUnmarshalUsers(t *testing.T) {
142142
ManageLists: false,
143143
ManageJobs: false,
144144
ViewJobs: false,
145+
CreateJobs: false,
146+
UpdateJobs: false,
147+
DeleteJobs: false,
145148
},
146149
},
147150
},

0 commit comments

Comments
 (0)