Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

Knock::AuthTokenController and auth parameter validation #181

Open
poulet42 opened this issue Aug 8, 2017 · 3 comments
Open

Knock::AuthTokenController and auth parameter validation #181

poulet42 opened this issue Aug 8, 2017 · 3 comments

Comments

@poulet42
Copy link

poulet42 commented Aug 8, 2017

To reproduce :

  • Setup Knock
  • Generate a token controller rails generate knock:token_controller XXX
  • Send a post request with a string parameter called auth to the generated endpoint

Expected response : Status 4XX
-> Bad parameters = Client issue

Actual response : Status 500 - Internal Server Error

@spaquet
Copy link

spaquet commented Aug 8, 2017

Just a quick question. You hcave XXX after token_controller. Did you change it by the model you plan to use (User or else)?

@poulet42
Copy link
Author

poulet42 commented Aug 9, 2017

@spaquet Yes, I'm using my User model

@jondoe1337
Copy link

Can confirm this. I would expect a 403 to be returned.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants