Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract_snp.py does not return phased snps? #351

Closed
shanwai1234 opened this issue Aug 12, 2020 · 2 comments
Closed

extract_snp.py does not return phased snps? #351

shanwai1234 opened this issue Aug 12, 2020 · 2 comments

Comments

@shanwai1234
Copy link

Hi Authors,

I am trying to use allele specific pipeline for HiC data processing. One script is extract_snp.py, although authors mention "phasing" in the tutorial, however, I look at the result and it seems all of return F1 is still unphased "0/1", which I assume it should be "0|1" or "1|0" as the output. Would this affect the real analysis for allele-specific HiC? Because I have 2 data with paternal and maternal exchanged. Thank you!

Hunter

@nservant
Copy link
Owner

nservant commented Sep 8, 2020

Hi Hunter,
That's a good comment. But indeed, I did not really take care of that.
The extract_snp.py utils is just there to process the Mouse sanger database vcf file, and as the goal is to extract the snps between the two strains, all variants will be "0/1" (in fact, this is hard-coded in the script ...)
Then, HiC-Pro will take all snps from the vcf file, regardless the genotyping nomenclature ...
Best

@nservant
Copy link
Owner

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants