Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a graceful exit for data generation script #4

Open
nshdesai opened this issue Jan 30, 2022 · 2 comments
Open

Figure out a graceful exit for data generation script #4

nshdesai opened this issue Jan 30, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@nshdesai
Copy link
Owner

It seems as though default signal handling doesn't work out of the box with the data generation script because big-sleep also uses this to gracefully exit during training.

So basically,

for prompt in prompts:
    imagine() # Handles graceful exit
    if terminate:
        exit() # This doesn't work because the top-level signal handler doesn't get called

This means that during each iteration imagine() thinks that the program has been terminated, but this message is not passed on to the script performing the loop.

@nshdesai nshdesai added the bug Something isn't working label Jan 30, 2022
nshdesai referenced this issue Feb 3, 2022

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
@baronet2
Copy link
Collaborator

baronet2 commented Feb 3, 2022

So you're saying there's no way to identify whether imagine() crashed?

@nshdesai
Copy link
Owner Author

nshdesai commented Feb 4, 2022

imagine() can handle its own interrupts (from user), but there's no obvious way to communicate this to the parent function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants