Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate access= and in_region= kwargs? #327

Open
jrbourbeau opened this issue Oct 23, 2023 · 0 comments
Open

Consolidate access= and in_region= kwargs? #327

jrbourbeau opened this issue Oct 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jrbourbeau
Copy link
Collaborator

Following up on #318 (comment)

I'm not sure why we have separate access and in_region kwargs for determining if we want to use s3 or https urls. Is one kwarg sufficient?

I think we want to, by default, use S3 access when on AWS in region us-west-2 and https paths otherwise. Based on

# Even though we are in us-west-2 the user wants the HTTPS links
# used in region they are S3 signed links from TEA
# https://github.com/asfadmin/thin-egress-app

it looks like we also want the ability to override this default for some special cases (seems reasonable). I think we can accomplish this with a single access= or in_region= or some other name kwarg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants