Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Soften" contributor requirements like unit tests #525

Open
mfisher87 opened this issue Apr 16, 2024 · 4 comments
Open

"Soften" contributor requirements like unit tests #525

mfisher87 opened this issue Apr 16, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@mfisher87
Copy link
Collaborator

Some contributing requirements may be intimidating users from contributing. Let's change our language in the contributing guide to indicate:

If you're not comfortable writing unit tests, we still welcome your contribution! Just please ask for help and someone from the community will do their best to work with you.

@doug-newman-nasa
Copy link
Contributor

As long as we don't merge any bug fixes/features without tests I'm OK with that.

@jhkennedy
Copy link
Collaborator

Yeah, I like saying it's okay to let PR CI/CD run the unit tests instead of needing to do it locally and it's okay to ask for help to make them pass

@mfisher87
Copy link
Collaborator Author

As long as we don't merge any bug fixes/features without tests I'm OK with that.

💯

@mfisher87 mfisher87 added the documentation Improvements or additions to documentation label Apr 16, 2024
@mfisher87
Copy link
Collaborator Author

I think a PR template is a good way to communicate the exact checklist in an accessible way, including the "ask for help" part. Then we can shorten the contributing doc a bit by linking to the PR checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants