Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dask tutorial notebook for now #569

Closed
mfisher87 opened this issue May 12, 2024 · 6 comments · Fixed by #599
Closed

Remove the dask tutorial notebook for now #569

mfisher87 opened this issue May 12, 2024 · 6 comments · Fixed by #599
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@mfisher87
Copy link
Collaborator

mfisher87 commented May 12, 2024

The dask tutorial notebook is not linked in the Mkdocs nav. Relevant discussion: #568 (comment)

  • Why was it removed from the nav? It wasn't! It was added as a comment to remind us to add it to the nav later when it was more complete.
  • Do we want to bring it back? Yes, but in a different form.
  • What needs to be done to bring it back? _@betolink working on it as part of smart_open (`smart_open()`: dynamically improving fsspec caching strategy. #527) work

Decision: Remove it for now!

@mfisher87
Copy link
Collaborator Author

The tutorial was never added as a nav item, it was always commented out: dab9da4

@betolink can you shed some light on this?

@mfisher87 mfisher87 added documentation Improvements or additions to documentation question A question needs to be answered to proceed labels May 12, 2024
@betolink
Copy link
Member

This was an initial toy example with Dask, I'm working on a version that works independently of Coiled but I don't think it will be ready until next month, hopefully by then we'll have smart_open=True released.

@mfisher87
Copy link
Collaborator Author

Should we remove this notebook so it can be replaced with the Coiled-independent version later?

@betolink
Copy link
Member

I think so.

@mfisher87 mfisher87 changed the title What to do with the dask tutorial notebook? Remove the dask tutorial notebook May 14, 2024
@mfisher87 mfisher87 added good first issue Good for newcomers and removed question A question needs to be answered to proceed labels May 14, 2024
@mfisher87 mfisher87 changed the title Remove the dask tutorial notebook Remove the dask tutorial notebook for now May 14, 2024
@Sherwin-14
Copy link
Contributor

@mfisher87 Hey Matt, is this issue still relevant? If yes, do you any specific opinions regarding this?

@mfisher87
Copy link
Collaborator Author

Still relevant. For this I think all we need to do is remove the notebook, since it's not linked to anything. Let's see if it breaks any tests or whatever :)

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in earthaccess project Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants