Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python (and other core dependency) support policy to our docs #573

Closed
3 of 4 tasks
mfisher87 opened this issue May 14, 2024 · 9 comments · Fixed by #763
Closed
3 of 4 tasks

Add Python (and other core dependency) support policy to our docs #573

mfisher87 opened this issue May 14, 2024 · 9 comments · Fixed by #763
Labels
documentation Improvements or additions to documentation enhancement New feature or request hackathon An issue we'd like to visit during a hackathon event
Milestone

Comments

@mfisher87
Copy link
Collaborator

mfisher87 commented May 14, 2024

IMO we should follow the Numpy policy and see how that works for us.

Follow up from discussion in #571

Tasks

  1. documentation
    Sherwin-14
@mfisher87 mfisher87 added this to the Version 1.0 milestone May 14, 2024
@mfisher87 mfisher87 added documentation Improvements or additions to documentation enhancement New feature or request labels May 14, 2024
@Sherwin-14
Copy link
Contributor

@mfisher87 Hey, Is this the policy that you are talking about https://jax.readthedocs.io/en/latest/deprecation.html. If yes then how should we implement this in our context?

@jhkennedy
Copy link
Collaborator

Numpy's Python version support policy is:
https://numpy.org/neps/nep-0029-deprecation_policy.html

Similarly, the scientific python policy is:
https://scientific-python.org/specs/spec-0000/

@mfisher87
Copy link
Collaborator Author

mfisher87 commented May 18, 2024

I think we're not decided yet on what policy we want to use. I personally think Scientific Python SPEC0 (as referenced by @Sherwin-14 link above, and based on NEP29) is where we want to be.

  • Support for Python versions be dropped 3 years after their initial release.
  • Support for core package dependencies be dropped 2 years after their initial release.

This means we could drop support for Python 3.9 now 🥳

@jhkennedy beat me to it

EDIT: Moving cc to a new post to ensure notifications go out. No idea if edits can trigger notifications from @

@mfisher87
Copy link
Collaborator Author

@'ing some folks I think may have opinions :) @betolink @andypbarrett @JessicaS11 @chuckwondo @asteiker @danielfromearth

@mfisher87
Copy link
Collaborator Author

I added a task list to the original post of this ticket. I think if whoever takes this up wants to break off the piece about updating our deps to another ticket, please do :)

@mfisher87 mfisher87 changed the title Add Python support policy to our docs Add Python (and other core dependency) support policy to our docs May 20, 2024
@mfisher87 mfisher87 added the hackathon An issue we'd like to visit during a hackathon event label Jul 9, 2024
@mfisher87
Copy link
Collaborator Author

Fairly positive emoji responses to request for consensus on SPEC0, maybe we can decide on the hackathon call rq. :)

@Sherwin-14
Copy link
Contributor

Sherwin-14 commented Sep 20, 2024

@mfisher87 Hey we have completed the 4th objective, what do you think about 2nd one? Do we need to create a Policies page or should we ignore this as it has already been mentioned in the backwards compatibility doc.

@mfisher87
Copy link
Collaborator Author

I think we can call that complete :) I wonder about number 3, are our dependencies already in compliance or do we need to make changes?

@mfisher87
Copy link
Collaborator Author

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in earthaccess project Oct 2, 2024
@mfisher87 mfisher87 linked a pull request Oct 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request hackathon An issue we'd like to visit during a hackathon event
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants