Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check stackitem jsonization #1190

Closed
roman-khimov opened this issue Jul 17, 2020 · 3 comments · Fixed by #1242
Closed

Check stackitem jsonization #1190

roman-khimov opened this issue Jul 17, 2020 · 3 comments · Fixed by #1242
Assignees
Milestone

Comments

@roman-khimov
Copy link
Member

neo-project/neo#1569 added direct stack item jsonization, we already have one defined in our code, but we need to check that it conforms to this format.

@roman-khimov roman-khimov added this to the v0.91.0 milestone Jul 17, 2020
@roman-khimov
Copy link
Member Author

And we need to apply it to app exec results (both exec result's stack and notification's state now use it). It also should be used for vm stack prints.

@roman-khimov
Copy link
Member Author

RPC invocations results also use it now.

@fyrchik
Copy link
Contributor

fyrchik commented Jul 29, 2020

C# ToJson fails for recursive structures, which may or may not be what we want for execution results, especially for FAULT states. I assume recursive structures are a of no use anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants