Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor common.Storage interface #2480

Open
cthulhu-rider opened this issue Aug 8, 2023 · 1 comment
Open

Refactor common.Storage interface #2480

cthulhu-rider opened this issue Aug 8, 2023 · 1 comment
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S2 Regular significance U4 Nothing urgent

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Aug 8, 2023

Originally posted by @carpawell

stands for BlobStor's sub-storages

Proposed changes:

  1. get rid of StorageID parameter from all ops and control identification in BlobStor scope
  2. add context.Context parameter to Put / Delete (or all) methods (see peapod.Peapod)
  3. use Storage.Type() as substorage ID persisted in metabase
  4. ???
@carpawell
Copy link
Member

add context.Context parameter to Put / Delete (or all) methods (see peapod.Peapod)

Iteration methods are the first candidates IMO.

@roman-khimov roman-khimov added enhancement Improving existing functionality U4 Nothing urgent S2 Regular significance I4 No visible changes and removed triage labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S2 Regular significance U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

3 participants