Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an abnormal behavior about the default config file #626

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

tivizi
Copy link
Contributor

@tivizi tivizi commented Jun 18, 2021

what's the abnormal behavior?

i stored my config.yaml to $HOME/.config/neofs-cli, but can't load to neofs-cli

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #626 (e90ae53) into master (adbbad0) will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #626      +/-   ##
==========================================
+ Coverage   42.91%   43.23%   +0.31%     
==========================================
  Files         202      203       +1     
  Lines        7999     8012      +13     
==========================================
+ Hits         3433     3464      +31     
+ Misses       4232     4211      -21     
- Partials      334      337       +3     
Impacted Files Coverage Δ
pkg/core/container/fmt.go 100.00% <0.00%> (ø)
pkg/morph/client/notary.go 0.00% <0.00%> (ø)
pkg/morph/client/constructor.go 0.00% <0.00%> (ø)
pkg/innerring/processors/audit/processor.go 0.00% <0.00%> (ø)
pkg/innerring/processors/netmap/processor.go 0.00% <0.00%> (ø)
pkg/innerring/processors/governance/processor.go 0.00% <0.00%> (ø)
pkg/innerring/processors/netmap/process_epoch.go 0.00% <0.00%> (ø)
pkg/innerring/processors/netmap/process_peers.go 0.00% <0.00%> (ø)
pkg/innerring/processors/netmap/process_cleanup.go 0.00% <0.00%> (ø)
.../innerring/processors/governance/process_update.go 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbbad0...e90ae53. Read the comment docs.

@alexvanin
Copy link
Contributor

Please update your commit message according to the commit style in this repository. It should contain PR number in the header and sign-off, e.g.

[#626] Support default config file

Signed-off-by: Name Surname <email>

Signed-off-by: Tivizi Jing <tivizi@163.com>
@alexvanin
Copy link
Contributor

alexvanin commented Jun 24, 2021

Also check DCO / Sign-Off linter error.


  c0a68bbcebe8a16dd14546bb1b32ec9973c59c06    Expected "tivizi <tivizi@163.com>", but got "Tivizi Jing <tivizi@163.com>".

  What should I do to fix it ?

  All proposed commits should include a Signed-off-by: <your-name> <your-email-address> line in their commit message.
  This is most conveniently done by using --signoff (-s) when running git commit.

Signed-off-by: Tivizi Jing <tivizi@163.com>
@tivizi
Copy link
Contributor Author

tivizi commented Jun 25, 2021

I changed my name in GitHub : )

@alexvanin alexvanin merged commit 1f461ba into nspcc-dev:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants