New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort public keys before Alphabet list merge #670

Closed

alexvanin opened this issue Jul 7, 2021 · 0 comments · Fixed by #688

Assignees

Labels

bug neofs-ir

Milestone

Contributor

alexvanin commented Jul 7, 2021

Noticed by @doubiliu

        // pkg/innerring/processors/governance/list_test.go:58
	t.Run("unsorted keys", func(t *testing.T) {
		orig := keys.PublicKeys{k[1], k[2], k[3], k[4]}
		exp := keys.PublicKeys{k[1], k[2], k[5], k[4]} // not sorted
		got, err := newAlphabetList(orig, exp)
		require.NoError(t, err)
		require.True(t, equalPublicKeyLists(exp, got)) // fails right now
	})

carpawell self-assigned this

carpawell mentioned this issue

Fix/sort keys before alphabet merge #688

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment