-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix placement assumptions in TestNodeManagement tests #599
Comments
These failures seems to be real bugs for me. Or I do not completely understand how storage policies work.
Due to nodes attributes, only one node should be used in this case (the s02, which has an attribute UN-LOCODE equal to RU LED) Another test scenario that fails uses this policy:
Although there is no 'Country' attribute in the node config, I see only two attrs in the storage node compose file in dev-env:
It is not quite clear to me what is the origin of this attribute.
It actually the same test, but the opposite filter, we filter here with EQ. And this test always passes. That makes me think there is probably some problem with NE statements. Same thing with the third failed test:
It uses NE inside FILTER expression - and nodes are chosen randomly. |
@evgeniiz321 It seems to be a nspcc-dev/neofs-node#2441 issue. |
problem was caused by dev-env, fixed - https://http.fs.neo.org/HXSaMJXk2g8C14ht8HSi7BBaiYZ1HeWh2xnWPGQCg4H6/582-1692787666/index.html |
Three tests from the
network
test suite that fail in this report are actually fine, we still have two copies, but they're placed a bit differently with SDK RC10 code.But notice that we're likely to have the same problem after nspcc-dev/neofs-node#2495 and while you can have some static assumptions about "correct" placement now you're not likely to have it after this change (what's the disk size on our runners? can it change?). So we either need to remove them from tests or set "capacity" attributes manually.
The text was updated successfully, but these errors were encountered: