Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locales cached in PrefManager and AssetCacheManager are not reconstructed properly #20

Open
GSala opened this issue Apr 28, 2020 · 0 comments
Open

Locales cached in PrefManager and AssetCacheManager are not reconstructed properly #20

GSala opened this issue Apr 28, 2020 · 0 comments
Labels
Android bug Something isn't working

Comments

@GSala
Copy link

GSala commented Apr 28, 2020

In the PrefManager (L45) and AssetCacheManager (L25) , Locales are constructed using the single parameter constructor which expects ISO 639 language codes.
The keys used in both of these managers are language tags that combine a language code and a country code.
They should probably use Locale.forLanguageTag()
@johsoe johsoe added the Android label Aug 3, 2020
@johsoe johsoe added the bug Something isn't working label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Android bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johsoe @GSala