Skip to content
This repository has been archived by the owner on Jun 6, 2021. It is now read-only.

Consider switching to the BrotliCompress available in Node.js API #92

Closed
ivan-aksamentov opened this issue May 25, 2019 · 1 comment
Closed

Comments

@ivan-aksamentov
Copy link

ivan-aksamentov commented May 25, 2019

Brotli compression algorithm has landed earlier this year into Node.js core and is exposed via zlib module since v11.7.0. This version of the compressor requires only Node.js itself and no other external modules or binaries.

Please consider switching to this algorithm on supported configurations, while falling back to binaries only where the new API is not available (on Node < 11.7.0), both during installation (that is, downloading/building binaries conditionally) and on runtime.

Potentially, the usage of the Node.js API can be made optional, via a new config flag, and possibly disabled by default until Node.js 12 enters LTS phase later this year.

I believe this change will alleviate the difficulties some of the users (and users of downstream packages) have with pre-built binaries and node-gyp, will definitely speed up the installation, as well as may give some more confidence regarding security. Personally, I am particularly interested to see the new algorithm to be used in gulp-brotli (see issue #5 there).

See also:

@nstepien
Copy link
Owner

nstepien commented Feb 1, 2020

iltorb is now a deprecated package, please use the zlib module directly.

@nstepien nstepien closed this as completed Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants