-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade MathJax to 2.7.2 and update config #30
Comments
The config for |
And of course that one is insane. It's literally every option. From MathJax's Getting Started
|
I think The For input I don't think we need to support MathML and AsciiMath in nteract unless people are expecting this feature in the notebook context. Using MathML for the output wouldn't make much sense for us since Electron and Chrome don't support it. I would also advocate against the HML-CSS fallback since it mainly targets legacy browsers. Either way I feel we shouldn't be using the combined configuration since they bundle the files which would be otherwise loaded on demand. This improves loading times over a CDN but, I don't think is useful in our context. Additionally I think we shouldn't included the |
I like your reasoning, plan, and outline @lgeiger. |
What do you say, CommonHTML or SVG? |
Since most of the rendering is controlled by React before it gets to MathJax, I feel like CommonHTML's speed limitation could be less of an issue. Reading about the CommonHTML output preprocessor, they seem to claim speed as one of its virtues:
Reading a bit more, the SVG mode is faster than the |
What do you think of the loading of fonts for CommonHTML? |
Maybe I misread the docs since CommonHTML is also HMTL-CSS based, there are 10x performance improvements expected anyway when moving to MathJax v3 so let's don't get caught up benchmarking. Let's try CommonHTML.
There are some LaTeX glyphs that are not covered by the included fonts these glyphs are then approximated by combining multiple character which can sometimes mess up spacing. For SVG this is not a problem since math is rendered as paths. Anyway since CommonHTML is the default renderer this can't be that big of a problem. |
One thing to check is the |
What I'm curious about for fonts is if we should load the fonts in advance like we do with Source Code Pro in Desktop. |
As much as possible, our custom build of mathjax electron should match the
TeX-MML-AM_CHTML
config with MathJax. That's certainly not the case right now as I found out in nteract/nteract#2350/cc @mpacer
The text was updated successfully, but these errors were encountered: