Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoping to get into upnp #817

Closed
lucktu opened this issue Sep 25, 2021 · 9 comments
Closed

Hoping to get into upnp #817

lucktu opened this issue Sep 25, 2021 · 9 comments
Milestone

Comments

@lucktu
Copy link
Contributor

lucktu commented Sep 25, 2021

This will increase the rate of p2p.
https://github.com/miniupnp/miniupnp

Thanks!

If you have any ideas, go over here please #147

@Logan007
Copy link
Collaborator

Logan007 commented Sep 25, 2021

Thank you for the pointer, it has already been mentioned here.

UPnP support still is an open action item and has also been discussed at #147. I therefore consider this a duplicate.

As it might become a hard-to-follow topic when wide-spread, please keep the discussion somewhat contained to one of the above mentioned. Thank you!

@lucktu
Copy link
Contributor Author

lucktu commented Sep 26, 2021

"it might become a hard-to-follow topic when wide-spread"?

I still don’t understand what this means. Something this good should be in it.

Anyone else have an opinion?

@skyformat99
Copy link
Contributor

Lightweight is the best mark for N2N, because there are so many embedded features to use.

if increase the rate of p2p, can use KCP with only two files:
https://github.com/skywind3000/kcp

@lucktu
Copy link
Contributor Author

lucktu commented Sep 26, 2021

Lightweight is the best mark for N2N, because there are so many embedded features to use.

if increase the rate of p2p, can use KCP with only two files:
https://github.com/skywind3000/kcp

Can you put it in your repositorie(or a new pull) that let us to test?
It seems that kcp only improves the transmission quality, not increase the rate of p2p.

In addition, the size of upnpc-static is only 82KB.

@Logan007
Copy link
Collaborator

Logan007 commented Sep 26, 2021

Something this good should be in it.

Yes, I fully agree. And I am not speaking against it.

what this means

I am just saying that we should not discuss UPnP across two or more different issues because the UPnP discussion is hard-to-follow then. Perhaps, we can discuss it at #147 or #562?

@lucktu
Copy link
Contributor Author

lucktu commented Sep 26, 2021

Actually, it's pretty clear what that means. There's nothing to discuss.

@Logan007
Copy link
Collaborator

Logan007 commented Sep 26, 2021

Actually, it's pretty clear what that means. There's nothing to discuss.

No, it does not mean that there is nothing to discuss.

Au contraire, I would gladly discuss how to implement UPnP support.

I just think that topics should be discussed at one place (one Issue), and not in two or more. That's all I kindly ask for... just for the sake of being able to keep and later find or retrieve information at one place... (and not at two or more).

@skyformat99
Copy link
Contributor

Actually, it's pretty clear what that means. There's nothing to discuss.

No, it does not mean that there is nothing to discuss.

Au contraire, I would gladly discuss how to implement UPnP support.

I just think that topics should be discussed at one place (one Issue), and not in two or more. That's all I kindly ask for... just for the sake of being able to keep and later find or retrieve information at one place... (and not in two or more).

agree,
close it ^_^

@lucktu lucktu closed this as completed Sep 26, 2021
@lucktu
Copy link
Contributor Author

lucktu commented Sep 26, 2021

Without a post like mine as a guide, that post is nowhere to be found

If you have any ideas, go over here please #147

@lucktu lucktu reopened this Sep 26, 2021
@Logan007 Logan007 mentioned this issue Oct 27, 2021
8 tasks
@Logan007 Logan007 added this to the 3.2 milestone Oct 31, 2021
@lucktu lucktu closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants