Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Thanks! #1

Open
coderschoolreview opened this issue Oct 17, 2016 · 1 comment
Open

Thanks! #1

coderschoolreview opened this issue Oct 17, 2016 · 1 comment

Comments

@coderschoolreview
Copy link

Overall

  • 👍 Thank you, this is a great submission.
  • The point of this homework was to explore some basic Android components with a RESTful API. You learned about ListView, custom ArrayAdapter and basic networking.

Good stuffs

  • My first comment is your source code is very clean 💻
  • I see that you can implement clearly project structure.
  • It good to see you define that one below, but I think it's better if you try to implement enum.
     private final int HIGH_RATING_MOVIE = 1;
     private final int NORMAL_RATING_MOVIE = 0;
  • Great job using ButterKnife to bind view.
  • Nice job implementing Retrofit for basic networking stuff. Hope you understand deeply this library.
  • Nice work using ArrayAdapter as customize with View Holder pattern. 👍 switch (type) to figure out 2 differents listview items.
  • Great to see you using Glide for loading image asychonously.
  • Great job seperating into detail models, with gson to parse JSON stuff.

Suggestions

  • Completely, you've gone so far on the first assignment. Keep moving!!!
  • I wish that you write down some challenges after each assignment, and how can you pass over all of them 💥 ✨
@ntvinhdev
Copy link
Owner

ntvinhdev commented Oct 19, 2016

Thanks for your review, Coderschool 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants