Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEC Explorer Table query issued twice #429

Open
chaitanyahalbe opened this issue Dec 16, 2020 · 7 comments
Open

FEC Explorer Table query issued twice #429

chaitanyahalbe opened this issue Dec 16, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@chaitanyahalbe
Copy link
Contributor

chaitanyahalbe commented Dec 16, 2020

@nxanil There was an enhancement request for FEC Explorer where there will be 2 Tables on 1 dashboard which have the same query. The query is invoked twice for each table. For optimization purposes, in this scenario, the query, since same query is used here, should only be invoked once.

Screenshot:
image

cc @killanch

@chaitanyahalbe chaitanyahalbe added the bug Something isn't working label Dec 16, 2020
@nxanil
Copy link
Collaborator

nxanil commented Dec 17, 2020

@chaitanyahalbe

I have checked at my end the query if invoke once for each visualization. Please check the below mention gif

tableQueryIssue

@killanch
Copy link
Contributor

@nxanil your observation is correct.
but the request is to optimize the current behavior.
in case there are no visualization-specific filters and the visualizations use the same query (using dashboard level filters), can we avoid the duplication query? the query will be exactly the same

@killanch
Copy link
Contributor

killanch commented Feb 2, 2021

@sreddy80 any update on this?
As per last comments in nuagenetworks/js-bambou#182, you were to test the war file

@sreddy80
Copy link

sreddy80 commented Feb 2, 2021

@killanch - I had verified the war file and spot checked Visualizations. As part of this verification, I had reported related issue on #434.
I need to bring up FEC setup for this, will check with Anamika on this.

@killanch
Copy link
Contributor

@sreddy80 any update on this? pls let me know in case you need an updated war file

@sreddy80
Copy link

@killanch - Did a sanity spot check on the graphs on this war file. Related Issue #434 is pending

@nxanil
Copy link
Collaborator

nxanil commented Apr 13, 2021

@chaitanyahalbe
This issue is already created ISSUE:182 and has been resolved there.
We can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants