Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable access logging for key value store #33

Open
gozer opened this issue Jul 20, 2015 · 5 comments
Open

Enable access logging for key value store #33

gozer opened this issue Jul 20, 2015 · 5 comments
Assignees
Milestone

Comments

@gozer
Copy link
Contributor

gozer commented Jul 20, 2015

Useful for auditing purposes

@tinnightcap tinnightcap changed the title Enable access logging for web UI access Enable access logging for key value store Nov 23, 2015
@tinnightcap
Copy link
Contributor

Web access can be logged via the ELBs or nginx can be placed in front. The issue is that when accessed through confd (aka local agent on remote node accessing over consuls RPC protocol) is not currently implemented in consul.

The correct solution here is a feature enhancement to consul itself to add access logging to the key / value store regardless of the access route.

@gozer
Copy link
Contributor Author

gozer commented Nov 24, 2015

Filed upstream issue: hashicorp/consul#1447
Filed upstream PR: hashicorp/consul#1448

@tinnightcap tinnightcap added this to the v2.1.0 milestone Oct 11, 2017
@gozer
Copy link
Contributor Author

gozer commented Nov 30, 2017

Right now, we can only enable this in consul by setting the log level to DEBUG, which includes lots of noise.

However, we do have access logging enabled on the SSO dashboard, which is the proxy into consul, so can we consider that as an alternate implementation of the feature ?

@jd? Thoughts ?

@jd
Copy link

jd commented Nov 30, 2017

Nop.

@tinnightcap
Copy link
Contributor

@gozer Interesting thought. I think this answers one part of the concern, which is human actors editing the k/v store. The other part is when the k/v store is edited by a host/node. This is commonplace, however if an instance is compromised, the k/v store may be edited and we still have no visibility into that.

In other words, this good progress in the right direction, but in my opinion does not resolve the issue in entirety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants