-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net5 tfm: "hydrating" empty TargetPlatformVersions #9444
Comments
We will be splitting the
If the platform version isn't specified in the NuGet should be reading from the 5 component properties in various scenarios, and that's how NuGet should be picking up what the target platform version is. Here's an issue tracking doing this in the targets for Windows: dotnet/sdk#11233 |
Reading the target frameworks in the inner build will make this possible. |
This will be fairly straightforward once #9756 is implemented. |
#9756 is merged, so this can probably be closed now. It might be nice to grab the latest SDK and verify the scenario once the NuGet insertion that should be started tomorrow completes. |
This is likely already done, and just needs to be tested against dotnet's changes. tl;dr, we need to check that when we multi-target net5.0 and net5.0-windows, that we have two different frameworks and we don't have a random "windows-7.0". Closing this in favor of #9873 |
NuGet itself doesn't have the information it needs in order to understand what version
net5.0-ios
and such might mean, but omitting versions is an important part of this feature.After discussions with the dotnet and msbuild teams, my understanding is that they will "fill in" the
NuGetFramework
instances with the actual version using some API call that's yet to be determined (or, preferably, hand us a new one, so we can keepNuGetFramework
immutable).The text was updated successfully, but these errors were encountered: