New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for modular TPCs in processing and plotting #71

Open

Will-D2099 opened this issue Nov 23, 2023 · 0 comments

Contributor

Will-D2099 commented Nov 23, 2023 •

edited

Loading

Now that nugraph/numl#11 is being closed I need to update the https://github.com/vhewes/pynuml/blob/main/pynuml/process/hitgraph.py to add the tpc center and the drift direction as features for the neural network.

I think we discussed using a dataframe join, but I'm not sure where to do that I assume it has to be before this part of the code is run https://github.com/vhewes/pynuml/blob/4203a2d7369d2ff77c80e5b61815a811b70ac8de/pynuml/process/hitgraph.py#L42-L58 since we will need this info in the hit table at this point in order to pass them as features (I think???).

I'm also not sure how to go about using the TPC info to make the plotting show the events continuous across tpc boundaries I suppose I will have to look more into the geometry of the DUNE FD to do it properly because I'm not sure how to convert the center info into wire offsets maybe it is something like this https://github.com/DUNE/dunereco/blob/3c4ab35ed7aa403685ef87ded6187e3f7f518764/dunereco/CVN/art/PixelMapProducer.cxx#L442C4-L460? I'm not sure though if there is a better way so any advice/insight is appreciated! Related to this I'm also a little confused about the reason that the positions are being rescaled here https://github.com/vhewes/pynuml/blob/4203a2d7369d2ff77c80e5b61815a811b70ac8de/pynuml/process/hitgraph.py#L155C5-L155C54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment