Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci: Fix version command reported wrong version #58

Merged
merged 2 commits into from
Jul 3, 2022

Conversation

nullpo-head
Copy link
Owner

Currently, Conventional Changelog Action runs after the packaging the release assets, the assets are built without the bumped version, thus distrod version reports the old wrong version instead of the bumped version. In addition, the action commits the built assets, which is unintended.

This PR fixes that problem by fixing the execution order of Conventional Changelog Action.

@nullpo-head nullpo-head merged commit fd9bbdc into main Jul 3, 2022
nullpo-head added a commit that referenced this pull request Jul 5, 2022
The fix introduced by #58 was not sufficient. This PR indeed makes cargo build for the latest updated version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant