-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are you interested in a Minpack wrapper? #63
Comments
@Nicholaswogan thank you for bringing this to our attention. One of the advantages of the However, it would be very, very nice to be able to use Lastly -- and this is probably a bit of a longshot -- how about looking into using LFortran as a compiler? It also uses LLVM (maybe even llvmlite, if I am not mistaken) and there do appear to be some interesting routes in that direction. |
@esc That makes sense. The gfortran dependency wouldn't be cross platform, so it makes sense it wouldn't be the best for
I'm very open to any of these ideas! More exposure would certainly lead to good ideas from the numba community for improving the wrapper. Let me know what I can do to help. |
I think the first step, which is also easy to get in, would be to mention NumbaMinpack in the numba-scipy documentation somewhere, either README or Sphinx or both. I'd be very open to accepting such a PR outright. This is actionable. Pulling the repo in the Numba organization is a much bigger step, that the current maintainers will need to agree on and getting that consensus may take some time. This is in my court and "in progress", I would say. |
@Nicholaswogan thanks for raising this (and writing the library!), really great to see Thanks for providing guidance here @esc, suggest that the various items mentioned above are discussed at the next public meeting (they are every Tuesday!) to gather some community feedback in relation to this sort of use case. |
@stuartarchibald Sounds great! I'll be at the public meeting this coming Tuesday. |
@stuartarchibald let me know when the build template we talked about in this meeting is put together, and I'll try it on Minpack. |
Great, thanks, will let you know! |
@stuartarchibald I also put together a similar wrapper to LSODA, for solving ordinary differential equations: https://github.com/Nicholaswogan/NumbaLSODA . I used CMake with setup.py to install so its more platform independent, but I don't think it would work on Windows right out of the box. |
@stuartarchibald I made a wrapper for Minpack, which can be called from within numba jit compiled functions: https://github.com/Nicholaswogan/NumbaMinpack . scipy.optimize.root uses minpack. The wrapper is a bit hacky, but it has worked well for me.
Wondering if you would be interested in implementing NumbaMinpack into numba-scipy. If so, I can put together a pull request, which would add a folder
numba-scipy/optimize
.The text was updated successfully, but these errors were encountered: