Merge pull request #1814 from numbersprotocol/fix-custom-camera-delete-file-after-discard-confirm

fix(custom-camera.page): remove capture after discard/approve

Author: bafu

src/app/features/home/custom-camera/custom-camera.page.ts

@@ -156,9 +156,9 @@ export class CustomCameraPage implements OnInit, OnDestroy {
     this.removeCurrentCapture();
   }
 
-  confirmCurrentCapture() {
+  async confirmCurrentCapture() {
     if (this.curCaptureFilePath && this.curCaptureType) {
-      this.customCameraService.uploadToCapture(
+      await this.customCameraService.uploadToCapture(
         this.curCaptureFilePath,
         this.curCaptureType
       );
@@ -179,7 +179,7 @@ export class CustomCameraPage implements OnInit, OnDestroy {
   }
 
   private removeCurrentCapture() {
-    // TODO: remove file this.curCaptureFilePath to free space
+    this.customCameraService.removeFile(this.curCaptureFilePath);
     this.curCaptureFilePath = undefined;
     this.curCaptureMimeType = undefined;
     this.curCaptureSrc = undefined;

src/app/features/home/custom-camera/custom-camera.service.ts

@@ -1,10 +1,12 @@
 import { HttpClient } from '@angular/common/http';
-import { Injectable } from '@angular/core';
+import { Inject, Injectable } from '@angular/core';
 import { DomSanitizer } from '@angular/platform-browser';
 import { Capacitor } from '@capacitor/core';
+import { FilesystemPlugin } from '@capacitor/filesystem';
 import { TranslocoService } from '@ngneat/transloco';
 import { PreviewCamera } from '@numbersprotocol/preview-camera';
 import { BehaviorSubject } from 'rxjs';
+import { FILESYSTEM_PLUGIN } from '../../../shared/capacitor-plugins/capacitor-plugins.module';
 import { CaptureService } from '../../../shared/capture/capture.service';
 import { ErrorService } from '../../../shared/error/error.service';
 import { blobToBase64 } from '../../../utils/encoding/encoding';
@@ -27,7 +29,9 @@ export class CustomCameraService {
     private readonly httpClient: HttpClient,
     private readonly captureService: CaptureService,
     private readonly errorService: ErrorService,
-    private readonly translocoService: TranslocoService
+    private readonly translocoService: TranslocoService,
+    @Inject(FILESYSTEM_PLUGIN)
+    private readonly filesystemPlugin: FilesystemPlugin
   ) {}
 
   private mediaItemFromFilePath(
@@ -89,6 +93,11 @@ export class CustomCameraService {
     return PreviewCamera.stopRecord().catch(() => ({}));
   }
 
+  async removeFile(filePath: string | undefined) {
+    if (!filePath) return;
+    await this.filesystemPlugin.deleteFile({ path: filePath });
+  }
+
   private changeGlobalCSSBackgroundToTransparent() {
     document.querySelector('body')?.classList.add(this.globalCSSClass);
     document.querySelector('ion-app')?.classList.add(this.globalCSSClass);