Merge pull request #2962 from numbersprotocol/fix-v230725-appsflyer-after-capacitor-5-migration

Fix v230725 appsflyer after capacitor 5 migration

Author: sultanmyrza

android/app/src/main/AndroidManifest.xml

@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools">
 
     <!-- Permissions -->
 
@@ -41,6 +42,9 @@
     <uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
     <!-- For in-app purchases -->
     <uses-permission android:name="com.android.vending.BILLING" />
+    <!-- https://dev.appsflyer.com/hc/docs/install-android-sdk#revoking-the-ad_id-permission -->
+    <uses-permission android:name="com.google.android.gms.permission.AD_ID"
+        tools:node="remove"/>
 
 
     <queries>

ios/App/Podfile.lock

@@ -18,7 +18,7 @@ PODS:
     - Capacitor
   - CapacitorClipboard (5.0.4):
     - Capacitor
-  - CapacitorCommunityAdvertisingId (1.0.0):
+  - CapacitorCommunityAdvertisingId (5.0.0):
     - Capacitor
   - CapacitorCommunityBluetoothLe (2.2.3):
     - Capacitor
@@ -223,7 +223,7 @@ SPEC CHECKSUMS:
   CapacitorBrowser: 2688852d02f1e89560a31b70521c71a5e7348860
   CapacitorCamera: 9b5c8e809c1042f263994f97ba846aa37e974f12
   CapacitorClipboard: 46f3959735fa0d96b9989dafcc4aed52e624d163
-  CapacitorCommunityAdvertisingId: ffbeee30080f0057f7af6e465a7552b68a3d3fdf
+  CapacitorCommunityAdvertisingId: 41543d8212fb12b6913b798bf1442c2a6bc1ae91
   CapacitorCommunityBluetoothLe: 7de4f21022a05b15195abfb002872884d00715fc
   CapacitorCommunityHttp: 7be90668527ef14ee10d08135b0e00fac9cf8247
   CapacitorCommunityWifi: 47188c74f2c6bcaefb619380863be8c67b1917c8

package-lock.json

@@ -31,7 +31,7 @@
     "@angular/router": "^14.2.0",
     "@awesome-cordova-plugins/core": "^5.46.0",
     "@awesome-cordova-plugins/in-app-purchase-2": "^5.43.0",
-    "@capacitor-community/advertising-id": "^1.0.0",
+    "@capacitor-community/advertising-id": "^5.0.0",
     "@capacitor-community/bluetooth-le": "^2.2.3",
     "@capacitor-community/http": "github:numbersprotocol/http#fix-catch-disabled-Local-Network-case-on-iOS",
     "@capacitor-community/wifi": "github:numbersprotocol/community-capacitor-wifi#capacitor3",

package.json

@@ -1,7 +1,8 @@
 import { Injectable } from '@angular/core';
 import { AdvertisingId } from '@capacitor-community/advertising-id';
+import { Capacitor } from '@capacitor/core';
 import { Platform } from '@ionic/angular';
-import { AFEvent, AFInit, AppsFlyer } from 'appsflyer-capacitor-plugin';
+import { AFInit, AppsFlyer } from 'appsflyer-capacitor-plugin';
 import { APPS_FLYER_DEV_KEY } from '../dia-backend/secret';
 
 @Injectable({
@@ -25,43 +26,33 @@ export class AppsFlyerService {
   constructor(private readonly platform: Platform) {}
 
   async initAppsFlyerSDK() {
-    await this.platform.ready();
+    try {
+      await this.platform.ready();
 
-    if (this.shouldInit === false) return;
+      if (this.shouldInit === false) return;
 
-    if (this.platform.is('ios')) {
       await AdvertisingId.requestTracking();
-    }
-
-    await AppsFlyer.initSDK(this.afConfig);
-  }
 
-  private get shouldInit() {
-    /**
-     * Do not init apps flyer SDK if dev key is not provided.
-     */
-    // eslint-disable-next-line no-extra-boolean-cast, @typescript-eslint/no-unnecessary-condition
-    if (!!APPS_FLYER_DEV_KEY) {
-      return false;
-    }
-    /**
-     * Do not init apps flyer SDK in Web environment.
-     */
-    if (!this.isNativePlatform) {
-      return false;
+      await AppsFlyer.initSDK(this.afConfig);
+    } catch (error) {
+      // TODO: Report error to Crashlytics or any other error reporting service if available.
     }
-    return true;
   }
 
-  async trackUserOpenedWalletsPage() {
-    if (this.isNativePlatform) return;
-
-    const data: AFEvent = { eventName: 'open-wallets-page' };
-
-    return AppsFlyer.logEvent(data).catch(() => ({}));
-  }
-
-  private get isNativePlatform() {
-    return this.platform.is('hybrid');
+  /**
+   * Determines whether AppsFlyer should be initialized.
+   * In APK debug or QA builds, we pass an empty string ("") as the APPS_FLYER_DEV_KEY
+   * to prevent AppsFlyer initialization. This approach helps avoid unnecessary analytics
+   * or install counts in development (DEV) or quality assurance (QA) builds.
+   * AppsFlyer will only be initialized if the following conditions are met:
+   * 1. The APPS_FLYER_DEV_KEY is truthy (not an empty string).
+   * 2. The app is running on a native platform (e.g., a mobile device).
+   *
+   * @returns {boolean} True if AppsFlyer should be initialized, otherwise false.
+   */
+  // eslint-disable-next-line class-methods-use-this
+  private get shouldInit() {
+    const isTruthy = Boolean(APPS_FLYER_DEV_KEY);
+    return isTruthy && Capacitor.isNativePlatform();
   }
 }