Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

上架的價格說明寫USD,但是最後上架卻變NUM單位 #1244

Closed
sync-by-unito bot opened this issue Feb 7, 2022 · 5 comments
Closed

上架的價格說明寫USD,但是最後上架卻變NUM單位 #1244

sync-by-unito bot opened this issue Feb 7, 2022 · 5 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Feb 7, 2022

Kenny Hung
Capture app
issues :上架的價格說明寫USD,但是最後上架卻變NUM單位
expectation: 上架與顯示幣別單位一致
steps to reproduce:
1.打開capture
2.點選圖片
3.點選右上角「更多動作」
4. List CaptureClub
5. 將原本設定價格刪除 顯示灰色說明文字

┆Issue is synchronized with this Asana task by Unito
┆Created By: Scott Yan

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 21, 2022

➤ Ray Hung commented:

James Chien
Frontend retrieves the placeholder text from bubble api.

getParams$(ids: string[]) {
return defer(() =>
forkJoin(
ids.map(id =>
this.httpClient
.get<GetParamResponse>(`${BUBBLE_DB_URL}/api/1.1/obj/param/${id}`)
.pipe(map(response => response.response))
)
)
);
}
(
getParams$(ids: string[]) {
return defer(() =>
forkJoin(
ids.map(id =>
this.httpClient
.get<GetParamResponse>(`${BUBBLE_DB_URL}/api/1.1/obj/param/${id}`)
.pipe(map(response => response.response))
)
)
);
}
). So, to fix this, should we update the bubble api response to “Price in NUM”? If so, should be a simple fix.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 21, 2022

➤ Ray Hung commented:

Tammy Yang

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 21, 2022

➤ Tammy Yang commented:

Ray Hung can you please share what ${BUBBLE_DB_URL} is?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 21, 2022

➤ Tammy Yang commented:

Just want to know which bubble app are we talking about here (there are many...)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Feb 21, 2022

➤ Ray Hung commented:

Tammy Yang
export NUMBERS_BUBBLE_DB_URL=https://numbers-upvote.bubbleapps.io ( https://numbers-upvote.bubbleapps.io )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants