v220830-capure-app-iframe release note (video)

[sync-by-unito]

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu for the release this Tuesday, since it's unscheduled release, we want to make the scope as small as possible. I have created a branch for you called v220829, please add video fix to this branch instead of the Development branch.

For this release (on 08/30), we only want "v220829 + video fix", nothing else, so that QA can focus on these issue fix and get ready for the next big release. If you believe there are some UI fixes which are small, and they should be included so that both QA and Dev can save some time and be more efficient, please feel free to do it, but please do remember to include those in the code review of v220830 release.

[sync-by-unito]

➤ Ethan Wu commented:

current fixed issues in 220829 branch:

UI
asset-page

• Group Product Full Image (Layout → uncheck fixed height (change to 20% - 60%, checked fit height to content) → this is to fix over large image covering up metadata. also fixes issues where there is suddenly large space between image and caption
• Group Product Full Image (Image asset Thumbnail) → checked collapse when hidden → resolve spacing issues when thumbnail height is greater than actual image itself
• Group Metadata → Group ID → Layout uncheck fixed width → change to 85% px to match previous element widths
• Group Metadata → Group ID → changed to Row layout (removed text and add link text) → this is to resolve alignment issues and full screen layout

asset-page (workflow)

• (explorer page is loaded) → added schedule display-product-info to step 3 of workflow because it was missing resulting in all products to show N/A for price.

index:

• Workflow (Page Loaded, Tag is empty, Tag Previous is not Tag)
  • Admin Storage Backend [Admin] - Get Product => remove "hinoki" from owner & creator. remove "limit = 10"
  • This is to enable lazy loading of products.

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu as mentioned, we want only 220829 + video fix. This is to make sure the version cam at least pass QA with some known issues (such as can only load 10 captures). I won't suggest adding lazy leading now as it increases risks significantly and may again slow down the performance.

UI or minor workflow fix looks good to me.

[sync-by-unito]

➤ Tammy Yang commented:

I believe we should add lazy loading and relative changes in the release next Tuesday.

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang ok. i can revert the lazy loading fixes. will record a claap showing ui things i have adjusted.

[sync-by-unito]

➤ Ethan Wu commented:

Tammy YangKenny Hung see clap for 220829 UI fix

https://app.claap.io/numbers-protocol/220829-capture-app-iframe-c-O35CsUM4Uy-ymB-VPtaGNXi ( https://app.claap.io/numbers-protocol/220829-capture-app-iframe-c-O35CsUM4Uy-ymB-VPtaGNXi )

https://app.claap.io/numbers-protocol/220829-capture-iframe-large-caption-fix-c-O35CsUM4Uy-PQ8qfKvtcVWQ ( https://app.claap.io/numbers-protocol/220829-capture-iframe-large-caption-fix-c-O35CsUM4Uy-PQ8qfKvtcVWQ )

[sync-by-unito]

➤ Ethan Wu commented:

Kenny HungTammy Yang video asset support

https://app.claap.io/numbers-protocol/video-support-capture-iframe-220829-c-O35CsUM4Uy-cUAw4a7awXRz ( https://app.claap.io/numbers-protocol/video-support-capture-iframe-220829-c-O35CsUM4Uy-cUAw4a7awXRz )

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu please remember to pull changes from "v220829-patch-fix-iOS-profile-page" savepoint of "qa-release" branch to your working branch as it is a fix for the critical issue.

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu all Claap watched, all good to be included in the release today. Here are the steps I believe we should do

1. Pull changes from "v220829-patch-fix-iOS-profile-page" savepoint of "qa-release" branch to your working branch as mentioned in the previous comment
2. If you have confirmed the fixes for ✓ [issue] Cannot open user_profile page on iOS ( https://app.asana.com/0/0/1202882626395618 ) has been included in your working branch, delete qa-release
3. Make a new qa-release from your working branch (v220829)
4. Delete v220829 branch
5. Submit QA release

[sync-by-unito]

➤ Ethan Wu commented:

i have already pulled changes from v220829-patch-fix-iOS-profile-page

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang made a small fix to the collected tab. all i did was reinitialize the api connector. see claap

https://app.claap.io/numbers-protocol/capture-iframe-v220829-collected-tab-fix-c-O35CsUM4Uy-xSjv51qlvXBZ ( https://app.claap.io/numbers-protocol/capture-iframe-v220829-collected-tab-fix-c-O35CsUM4Uy-xSjv51qlvXBZ )

[sync-by-unito]

➤ Ethan Wu commented:

release: https://dt42-numbers.slack.com/archives/CUSDE44MD/p1661842648214499 ( https://dt42-numbers.slack.com/archives/CUSDE44MD/p1661842648214499 )