[FR] caption should let user edit on rebrand design

[sync-by-unito]

Reproduce step

1. on profile tab & choose an asset
2. on detail-page, user can't edit the caption on new design UI

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

[sync-by-unito]

➤ Kenny Hung commented:

Tammy YangEthan Wu
Just confirm about caption edit

1. in old design user can edit their asset's caption
2. in new design, user can't edit it

In the original design document, it seems can let user edit caption.

[sync-by-unito]

➤ Ethan Wu commented:

Kenny Hung your right. in the design users can edit caption. however to my knowledge this page / feature was not apart of the release.

[sync-by-unito]

➤ Tammy Yang commented:

Kenny Hung what do you mean “old” and “new” design 😆

[sync-by-unito]

➤ Tammy Yang commented:

And, yes, as Ethan mentioned, we will not supoort this yet.

[sync-by-unito]

➤ Tammy Yang commented:

As there is an inconsistency between the design and the implementation, priority should be High (Must) instead of Medium (Better to have)

[sync-by-unito]

➤ Kenny Hung commented:

Okay, I got it.
I mean old design is before rebrand & new design is after rebrand.😂

[sync-by-unito]

➤ Ethan Wu commented:

user can edit caption in profile tab (asset view). see screen recording.

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu some questions need you to clarify.

#1
According to the flow of user_profile page ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764532097370813&cot=14 ) , you already have "user_name" as the page parameter. Why would you need "current user"? If you are trying to create two parameters, one for storing user_name acquired from page parameter and another one for the actual user name getting from the backend, at least, the naming should be consistent. Maybe call one "user_name" and another one "current_user_name" to reduce the confusion?

[sync-by-unito]

➤ Tammy Yang commented:

#2
The custom event get_follow_info can access URL parameter (see 2.png), what's the need of storing access token as page parameter (see 1.png)? Since token sensitive info and we should always the storage of it and reduce the risks of leakage.

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang

#1) we have current_user because we need to disable the FOLLOW button if the user is viewing their own profile. See step 4 in get_follow_info custom event.

#2) I believe you are correct for this one. token information can be accessed via the url parameter. I can make the adjustment.

[sync-by-unito]

➤ Tammy Yang commented:

Ethan Wu

For #1, can you please rename it as "login_user"?
For #2, if you can get the refresh_token from page URL, shouldn't we generate the access only when the follow button is pressed? Is it doable and more secure solution?

[sync-by-unito]

➤ Ethan Wu commented:

Tammy Yang

1. yes i can change to login_user
2. i can edit the follow / unfollow to use refresh_token on press instead of page load.

[sync-by-unito]

➤ Ethan Wu commented:

fix: https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764538622397916&cot=14 ( https://miro.com/app/board/o9J_knEiIYo=/?moveToWidget=3458764538622397916&cot=14 )