-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v221129-authmedia Make sure the signature used in Multi-uploader and CC is correct #2159
Comments
➤ Ethan Wu commented: asset: bafybeihcizd3wo5qbd3fiuhtakqg5j7tyeew4ftvpsr5nufcb5poae2mai proof_hash: 59aee2c44b3fa535fef25ad3142e413b01c75a5f6552c8f71ed899523eb43ca3 "signature": [ Bofu ChenTammy Yang the proof_hash are the same |
➤ Tammy Yang commented: nit signature created [{ "integrityHash": "b12d1f5b4653e4f2095c674c9ae8e6b43eed513a811cd3733a50be97788536c0", |
➤ Tammy Yang commented: Ethan Wu can you please do me a favor? |
➤ Tammy Yang commented: According to Bofu Chen's comment in the parent task, I believe proofHash is actually not relevant at all. We have new and better ways to assure the integrity. What we can do
|
➤ Tammy Yang commented: Suggested metadata to be signed
Next:
After this is done, the Captures should be able to show in the App no matter App is updated or not. |
➤ Ethan Wu commented: the issue was the metadata didn't match the signed metadata. it now shows up properly. Sam doesn't need to change any parameters on his end and it will show up. |
➤ Tammy Yang commented: I think it's still good to update the Signature, but we can do it in the next sprint. Thank you for clarifying the issue! |
➤ Ethan Wu commented: Tammy Yang will be working on this one. if so than i think we need to make a decision on what the signature should be. |
➤ Tammy Yang commented: Metadata {"information": [{"provider": "Numbers API", "name": "version", "value": "v2022"}, {"provider": "Numbers Co., Ltd.", "name": "API version", "value": "v2"}]} Signature [{ "integrityHash": "b12d1f5b4653e4f2095c674c9ae8e6b43eed513a811cd3733a50be97788536c0", "provider": "nit", "signature": "0x197e79174db7b87599d825e2bd63590bcad74d43beaa6e92c34d57323221963e57e88a8eacb17262bb934f4438c6f06aa5ab6f002951d9a959438d07105f46101b", "signer": "0x63B7076FC0A914Af543C2e5c201df6C29FCC18c5" }] |
➤ Tammy Yang commented: Let's use the same as Numbers API (since all captures are created via API) |
➤ Tammy Yang commented: Reference from Numbers API Bubble App |
➤ Kenny Hung commented: Ethan Wu Please help to update this task progress, thanks. |
➤ Ethan Wu commented: Kenny Hung sorry i missed the comments made by tammy. you can move this task to 11.21 sprint release |
➤ Ethan Wu commented: verified it shows up in capture app |
➤ Kenny Hung commented: Ethan Wu about this release I just make sure "signature" will like as below and it could display on capture app, right? |
➤ Ethan Wu commented: Yes |
More details see parent task and https://dt42-numbers.slack.com/archives/C3CHPJTS4/p1665038836912919
┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang
The text was updated successfully, but these errors were encountered: