Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] When the prod is unpublish, the NUM price should be turn back to "UNLIST" #2340

Closed
sync-by-unito bot opened this issue Nov 25, 2022 · 29 comments
Closed

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 25, 2022

Your email:
kennyhung@numbersprotocol.io

Select product:
Capture App

One line to describe the issue you see or the feature you want to add:
When the prod is unpublish, the NUM price should be turn back to "UNLIST"

Let us know what do you expect to see?:
When the prod is unpublish, the NUM price should be turn back to "UNLIST"

Please provide some simple steps to help us reproduce the issue or understand how do you want to see the feature.:

  1. choose an asset which has been listed
  2. press options button
  3. choose "unpublish"
  4. NUM price should turn back to "UNLIST"

What's the device or browser do you use?:
Oppo Reno6Z/ iphone 8

———————————————
This task was submitted through Issue Report/Feature Request
https://form.asana.com/?k=OlNjzNIasZt0uOT5gzb7pw&d=1200886955782960

┆Issue is synchronized with this Asana task by Unito

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

Tammy Yang
This task needs your confirmation. Do we let price[NUM] turn back to "UNLISTED"?

Sam (cc Ethan Wu) I think this should be iframe part? If yes, I think this task should be re-arranged.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Kenny Hung, if it's an asset details page it might be an iframe part, Ethan Wu?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Ethan Wu commented:

Sam I'm thinking what needs to happen is after the user unlists you need to refresh the page so the information is updated

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Ethan Wu, when user unlist he click "save" button?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

if he clicks save button ionic side will go back and reload the iframe.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Ethan Wu commented:

Sam no. asset_page loads data from backend on page load. In order for the information to be updated it will need fresh data grab from backend to update.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Ethan Wu commented:

Kenny HungSam can I see what the unpublish flow looks like. Can I see a video recording

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Ethan Wu, I think I misunderstood. Unpublish is an Ionic component. I think it's ionic side task.😅

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Kenny Hung, just to clarify we are talking about this button ( https://i.imgur.com/jVWDhyB.png )?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

Sam Yes, because the latest version when user unpublish(disable prod) the NUM price still display the original price.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Kenny Hung, how can I list an asset? To test unpublish? Is mint and share same as listing?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

Sam list an asset

  1. choose an asset
  2. operate network action "mint & share"

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Kenny Hung, once I "Mint & share" how can I verify it's minted?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Kenny Hung, and once I do "unpublish" how can I verify it?

I mean should I use nftse to double-check? Or..?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

Sam

  1. Listing process will include mint nft.
  2. And complete listing, will display NUM price you set on network action.
  3. When you operate "Unpublish", that prod won't display on explore page.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Ethan Wu, I tried to "Mint & Share" for 3NUMs and received an email that it was minted etc.
The email contained this link https://captureclub.cc/product?pid=a58fcefb-5561-4479-9f0a-00422e5618b1 ( https://captureclub.cc/product?pid=a58fcefb-5561-4479-9f0a-00422e5618b1 )

Once it was minted the BUY button is enabled in the capture club for the product.
Then from the capture app, I click "Unpublish" and if I go to capture club for the same product "Buy" button is disabled [screenshot ( https://i.imgur.com/PHhv6Bj.png )].

However captureiframe ( https://captureappiframe.numbersprotocol.io/asset_page?from=explorer&nid=bafybeiepnqbw2ud6mhxu24am62tmuq75wadao6owxfcdxqt3xlokcwufdi ) still shows 3NUMs instead of UNLISTED.

Unpublish method changes are reflected on capture club but seems not reflected on cpatureiframe.

My question is how we get this value ( https://i.imgur.com/dDr0EgJ.png ) in capture iframe? Do we check if it's unpublished first?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Ethan Wu commented:

Sam ok than I think I need to add a conditional statement for diabled assets

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Ethan Wu, please let me know when it's done I can do the testing to confirm the changes.🙏

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Ethan Wu commented:

Which branch are you testing with?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

prod https://captureappiframe.numbersprotocol.io

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Ethan Wu

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Ethan Wu commented:

Ok. Any changes I make won't be reflected until it's deployed (post release)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Sam commented:

Ethan Wu, which branch you made chages? I mean if I change to the branch you updated can I test it?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 1, 2022

➤ Kenny Hung commented:

SamEthan Wu Just confirm, this task haven't been fixed on iframe-v221129 or ionic 0.70.0, right?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 1, 2022

➤ Sam commented:

It was fixed by Ethan Wu but I’m not sure if it’s published to iframe-v221129

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 1, 2022

➤ Sam commented:

Because it’s fixed on iframe side no changes needed for ionic 0.70.0

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 1, 2022

➤ Ethan Wu commented:

this has been addressed on the iframe side

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 1, 2022

➤ Ethan Wu commented:

you will need to wait until it is deployed to test this feature

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Dec 1, 2022

➤ Kenny Hung commented:

Ethan Wu (cc Sam) Got it, I'll test it on the 0.70.0 after the iframe-v221129 deployed.

@sync-by-unito sync-by-unito bot closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants