Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v230808-capture-app-iframe #2906

Closed
sync-by-unito bot opened this issue Jul 14, 2023 · 13 comments
Closed

v230808-capture-app-iframe #2906

sync-by-unito bot opened this issue Jul 14, 2023 · 13 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 14, 2023

﹍Product code:﹍

capture-iframe

﹍Release milestone:﹍

v230808-capture-app-iframe

﹍Testing level:﹍

  • C. Feature test

﹍Release note:﹍

  • when user swaps NUM from metamask browser it will redirect back to capture wallet page via the deeplink => removed because deeplink not working in metamask browser

﹍Expectation:﹍

  • when user swaps NUM from metamask browser it will redirect back to capture wallet page via the deeplink => removed because deeplink not working in metamask browser

﹍Known Issue:﹍

  • this is all dependent on whether or not deeplink is set up properly on the ionic side.
  • deeplinking not working in metamask browser

﹍Limitation:﹍

﹍Test Link﹍:

https://captureappiframe.numbersprotocol.io/version-66b4/

﹍Note:﹍

﹍Testing Results (add this after QA test)﹍:

﹍Testing Plan (add this after QA test):﹍

Testing Levels:

  • A. Full test + backward compatibility
  • B. Full test, no backward compatibility
  • C. Feature test
  • D. Issue fix retest
  • E. Growth

┆Issue is synchronized with this Asana Milestone by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot changed the title v230725-capture-app-iframe v230808-capture-app-iframe Jul 16, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 7, 2023

➤ Kenny Hung commented:

Ethan Wu Just confirm, this version will be include ✓ v230711-capture-app-iframe ( https://app.asana.com/0/0/1204942805264674 ) & ✓ v230627-capture-app-iframe (re-release) ( https://app.asana.com/0/0/1204832941075902 )?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 7, 2023

➤ Ethan Wu commented:

yes i will combine Kenny Hung

@sync-by-unito sync-by-unito bot closed this as completed Aug 10, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 11, 2023

➤ Kenny Hung commented:

Ethan Wu (cc Tammy YangScott Yan) v230808-iframe QA found some issues, please help to fix.

  1. ✓ [Issue] When the process of "swap NUM" is completed, user still stays on the metamask browser instead of returning Capture App automatically ( https://app.asana.com/0/1201016280880500/1204804397935686 )
    1. It will stay on this screen, it doesn't redirect & the completed screen is also different with live version

image.png2. [issue] SEND page display weird on iOS device ( https://app.asana.com/0/1201083422707776/1205228864244809/f ) → I suggest RWD for iOS, you could try on safari.

image.png

  1. The text on Deposit page

image.png

If #2 needs more time, we could skip this time & move to patch sprint(0814).

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 11, 2023

➤ Ethan Wu commented:

done

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 11, 2023

➤ Kenny Hung commented:

Ethan Wu

Double confirm, #1 is also done?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 11, 2023

➤ Ethan Wu commented:

yes

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 11, 2023

➤ Kenny Hung commented:

Tammy YangEthan Wu (cc SamScott Yan)

Needs your confirmation.

We need to reschedule [Issue] When the process of "swap NUM" is completed, user still stays on the metamask browser instead of returning Capture App automatically ( https://app.asana.com/0/1201016280880500/1204804397935686/f ), because our current solution can't work on metamask browser.

Detail ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1691748873471999?thread_ts=1691747811.816599&cid=C0323488MEJ ) & testing claap ( https://app.claap.io/numbers-protocol/issue-redirect-fail-from-metamask-c-O35CsUM4Uy-pXTkp59--N6R ).

This milestone has been included the ✓ v230711-capture-app-iframe ( https://app.asana.com/0/0/1204942805264674 ) feature.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 13, 2023

➤ Tammy Yang commented:

Kenny Hung what happens if you just go back to Capture Cam after transaction completes?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 14, 2023

➤ Kenny Hung commented:

Tammy Yang

The SWAP is completed, it is just the redirect failure.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 14, 2023

➤ Ethan Wu commented:

Tammy Yang to clarify the SWAP happens in MetaMask Browser.

Before after the transaction competes the SWAP page will inform users to manually return back to Capture App.

For this release we wanted to do that automatically by setting up a deeplink. that will open up Capture App Wallet page, however currently there are issues with Deeplink compatibility with the MetaMask browser.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 14, 2023

➤ Kenny Hung commented:

Tammy Yang (cc Ethan Wu)

My proposal is

Drop [Issue] When the process of "swap NUM" is completed, user still stays on the metamask browser instead of returning Capture App automatically ( https://app.asana.com/0/inbox/1201776223124520/1204804397935686/1205217942354053 ) from this milestone.

Because this release also includes the SEND page UI fixed on iOS, I suggest this part could go to next step.

BTW, in the future sprint, maybe we could have two parts to consider to enhance the UX of SWAP NUM

1. Could change "Copy link" to let user could press this button then lead to metamask browser.
2. Research how to redirect user from metamask browser after SWAP is completed.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 14, 2023

➤ Tammy Yang commented:

Ok

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 17, 2023

➤ Kenny Hung commented:

Ethan WuTammy Yang (cc Scott Yan) iframe-v230808 qa conditional pass.

  1. [issue] iframe UI/UX can't be displayed normally on Samsung device ( https://app.asana.com/0/1201016280880500/1203045412906822/f ) → Conditional pass, current live version also have the same issue
  2. [FR] "Copy link" button to let user could press this button then lead to metamask browser. ( https://app.asana.com/0/1201083422707776/1205290187454747/f ) → For enhancing UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants