-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v230808-capture-app-iframe #2906
Comments
➤ Kenny Hung commented: Ethan Wu Just confirm, this version will be include ✓ v230711-capture-app-iframe ( https://app.asana.com/0/0/1204942805264674 ) & ✓ v230627-capture-app-iframe (re-release) ( https://app.asana.com/0/0/1204832941075902 )? |
➤ Ethan Wu commented: yes i will combine Kenny Hung |
➤ Kenny Hung commented: Ethan Wu (cc Tammy YangScott Yan) v230808-iframe QA found some issues, please help to fix.
2. [issue] SEND page display weird on iOS device ( https://app.asana.com/0/1201083422707776/1205228864244809/f ) → I suggest RWD for iOS, you could try on safari.
If #2 needs more time, we could skip this time & move to patch sprint(0814). |
➤ Ethan Wu commented: done |
➤ Kenny Hung commented: Ethan Wu Double confirm, #1 is also done? |
➤ Ethan Wu commented: yes |
➤ Kenny Hung commented: Tammy YangEthan Wu (cc SamScott Yan) Needs your confirmation. We need to reschedule [Issue] When the process of "swap NUM" is completed, user still stays on the metamask browser instead of returning Capture App automatically ( https://app.asana.com/0/1201016280880500/1204804397935686/f ), because our current solution can't work on metamask browser. Detail ( https://dt42-numbers.slack.com/archives/C0323488MEJ/p1691748873471999?thread_ts=1691747811.816599&cid=C0323488MEJ ) & testing claap ( https://app.claap.io/numbers-protocol/issue-redirect-fail-from-metamask-c-O35CsUM4Uy-pXTkp59--N6R ). This milestone has been included the ✓ v230711-capture-app-iframe ( https://app.asana.com/0/0/1204942805264674 ) feature. |
➤ Tammy Yang commented: Kenny Hung what happens if you just go back to Capture Cam after transaction completes? |
➤ Kenny Hung commented: Tammy Yang The SWAP is completed, it is just the redirect failure. |
➤ Ethan Wu commented: Tammy Yang to clarify the SWAP happens in MetaMask Browser. Before after the transaction competes the SWAP page will inform users to manually return back to Capture App. For this release we wanted to do that automatically by setting up a deeplink. that will open up Capture App Wallet page, however currently there are issues with Deeplink compatibility with the MetaMask browser. |
➤ Kenny Hung commented: Tammy Yang (cc Ethan Wu) My proposal is Drop [Issue] When the process of "swap NUM" is completed, user still stays on the metamask browser instead of returning Capture App automatically ( https://app.asana.com/0/inbox/1201776223124520/1204804397935686/1205217942354053 ) from this milestone. Because this release also includes the SEND page UI fixed on iOS, I suggest this part could go to next step. BTW, in the future sprint, maybe we could have two parts to consider to enhance the UX of SWAP NUM
|
➤ Tammy Yang commented: Ok |
➤ Kenny Hung commented: Ethan WuTammy Yang (cc Scott Yan) iframe-v230808 qa conditional pass.
|
﹍Product code:﹍
capture-iframe
﹍Release milestone:﹍
v230808-capture-app-iframe
﹍Testing level:﹍
﹍Release note:﹍
﹍Expectation:﹍
﹍Known Issue:﹍
﹍Limitation:﹍
﹍Test Link﹍:
https://captureappiframe.numbersprotocol.io/version-66b4/
﹍Note:﹍
﹍Testing Results (add this after QA test)﹍:
﹍Testing Plan (add this after QA test):﹍
Testing Levels:
┆Issue is synchronized with this Asana Milestone by Unito
┆Created By: Kenny Hung
The text was updated successfully, but these errors were encountered: