Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] Rectify Tag Options Display Issue on Edit Caption Page #2998

Closed
sync-by-unito bot opened this issue Aug 21, 2023 · 21 comments
Closed

[issue] Rectify Tag Options Display Issue on Edit Caption Page #2998

sync-by-unito bot opened this issue Aug 21, 2023 · 21 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 21, 2023

User story

As a user, I want the tag options to be displayed normally on the edit caption page, ensuring that I can select tags easily.

Reproduce step

  1. Go to Capture Cam & press one asset
  2. Enter to asset detail page & press options list, press "edit"
  3. Enter to edit page, press tag dropdown list
  4. User can't see the text of tags easily.

IMG_5E240439735F-1.jpeg

Expectation

The tag options to be displayed normally on the edit caption page

Additional information:

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito sync-by-unito bot closed this as completed Aug 31, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Aug 31, 2023

➤ Ethan Wu commented:

Kenny HungScott Yan done

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2023

➤ Kenny Hung commented:

Ethan Wu

QA found the tag can't be updated when user open "list capture for sale."

  1. when user is on the edit page
  2. input caption
  3. choose a tag
  4. open "list capture for sale."
  5. input price & press mint & share
  6. When process finished, this asset doesn't have this tag. (User enter edit page again.)

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 7, 2023

➤ Ethan Wu commented:

Ok I will investigate this

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

Kenny Hung pls test

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Kenny Hung commented:

Ethan Wu It could work.

There is another question, the tag affect the search of the explore page?

I try to search "animal", but it will show "no search result". And the results of searching "animals" & "Animal" are also shown different asset.

photo1694138243.jpeg

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

Kenny Hung if there is an issue with the search function in the explorer page pls open a new task on asana and assign in next sprint.

filter search and search bar function in explorer page implementations were not touched for a really long time. if there are issues than it should be part of the testing plan.

but to answer your question, the search relies on tags to filter out options. basically you will need to search the exact tag (word for word) in order for it to show up.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Kenny Hung commented:

Ethan Wu Thanks. I set "Animal" on the edit page, but when I search "Animal" or press filter "Animal". That asset doesn't display on the list.

I think there are some issues on the search function in the explorer page.

But this time I think it could be conditional pass.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

Kenny Hung which photo is it?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Kenny Hung commented:

Nid: bafybeib7u3lanqfldprt4dhkqj27yzaqboyr3xvzwkfujj5cnwstfjhr2i

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

it works. did you wait long enough?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

pls open a task i will investigate and fix this issue

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Kenny Hung commented:

Thanks, just final check

  1. Does the tag on the edit page apply the tag in the product? (As my testing, the answer should be no.
  2. The search of the explore page relied on tag of the product, my understanding is right?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

Kenny Hung that is correct. the explorer page searches based on the product tag

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Kenny Hung commented:

Ethan Wu Sorry, I found a new issue on edit page.

User can't just add a tag.

  1. enter edit page, choose a tag & save.
  2. It doesn't have any feedback.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

Kenny Hung you want me to fix both 1 and 2?

2 cannot be fixed.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

they are inherently different

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Kenny Hung commented:

Ethan Wu Okay, #2 I'll open another card for it. It could be fixed in the future.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Kenny Hung commented:

Ethan Wu when you finish #1, please ping me, thanks.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

Kenny Hung im working on the dev slides. will take a look afterwards. does this one need to be fixed in this sprint. i think the issue is totally different from what the original asana card.

i didn't touch the edit caption page implementation at all as this task was supposed to be just a UI fix. this tag issue that you mentioned should be added to the testing plan so that it doesnt get missed in future.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Kenny Hung commented:

Okay, I'll open another card for it.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Sep 8, 2023

➤ Ethan Wu commented:

thanks! if i finish the slides i will work on it and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants