-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a nit module to combine all latest information in AssetTree #18
Comments
➤ Tammy Yang commented: Working on status page this sprint, push the task to 23.03.27 |
➤ Tammy Yang commented: Suggest to create some miro flow and discuss with Bofu Chen first. |
➤ Olga commented: Tammy YangBofu Chen There are two different implementations:
I believe that the performance of #2 is better because it always retrieves the latest asset tree and combines it with the added one. On the other hand, #1 needs to retrieve all asset trees and combine them with the added one. I suggest updating the #1 implementation to match the approach used in #2. However, if you prefer to keep the "nit" module aligned with the #1 implementation, we can introduce a new command called "nit merge" to display the merged asset tree. Please let me know your thoughts on this approach. |
➤ Bofu Chen commented: Olga I'm checking the material above |
➤ Bofu Chen commented: Olga 先走 nit merge (align with the #1 implementation) data sources 為四個鏈:Numbers, Ethereum, Avalanche, NEAR 我們的目標是先有第一版實作,並瞭解執行效能 可以預期效能一開始不會太好,因此麻煩測試實作時,紀錄幾個效能指標
|
➤ Olga commented: Bofu Chen please help review PR 28 for the nit #28 ( #28 ). The performance varies for each blockchain. The time to retrieve assetTrees depends on whether the file is already on the public gateway. $ ./bin/nit.js merge aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa For Numbers with 24 blocks:
For Avalanche with 21 blocks:
For Ethereum with 1 block:
$ ./bin/nit.js merge bafkreid2izzo5nk4g5edzcd7toyxpfg57m53nx2ggvaropy755a5j2k3pu I use the CID because aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa is not available on Aurora. For Aurora with 2 blocks:
|
➤ Tammy Yang commented: bafkreiafr2brcwink7zfoa4tbvjrmhpnw2hyr22gygk2ccjwyt4bqwehmm |
➤ Olga commented: $ ./bin/nit.js merge bafkreiafr2brcwink7zfoa4tbvjrmhpnw2hyr22gygk2ccjwyt4bqwehmm The assetTrees are timing out from the w3s, so I have changed the IPFS source to Numbers. Jade 4 blocks:
Aurora 1 block:
|
Problem:
Current NSE shows the information from the latest assetTree. However, it is also possible that the important information such as creator is not included in the latest commit.
It will be good if we can pull information from all AssetTree and create a latest snapshot of the asset. This will has different meaning of the latest AssetTree but should be useful.
┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang
The text was updated successfully, but these errors were encountered: