rust: Also disallow . in Rust library target names

Author: sdroege

mesonbuild/backend/ninjabackend.py

@@ -1892,8 +1892,8 @@ def generate_rust_target(self, target: build.BuildTarget) -> None:
             args.extend(rustc.get_linker_always_args())
 
         args += self.generate_basic_compiler_args(target, rustc, False)
-        # Rustc replaces - with _. spaces are not allowed, so we replace them with underscores
-        args += ['--crate-name', target.name.replace('-', '_').replace(' ', '_')]
+        # Rustc replaces - with _. spaces or dots are not allowed, so we replace them with underscores
+        args += ['--crate-name', target.name.replace('-', '_').replace(' ', '_').replace('.', '_')]
         depfile = os.path.join(target.subdir, target.name + '.d')
         args += ['--emit', f'dep-info={depfile}', '--emit', 'link']
         args += target.get_extra_args('rust')

mesonbuild/build.py

@@ -1988,8 +1988,8 @@ def post_init(self) -> None:
             elif self.rust_crate_type not in ['rlib', 'staticlib']:
                 raise InvalidArguments(f'Crate type "{self.rust_crate_type}" invalid for static libraries; must be "rlib" or "staticlib"')
             # See https://github.com/rust-lang/rust/issues/110460
-            if self.rust_crate_type == 'rlib' and any(c in self.name for c in ['-', ' ']):
-                raise InvalidArguments('Rust crate types "dylib" and "proc-macro" do not allow spaces or dashes in the library name '
+            if self.rust_crate_type == 'rlib' and any(c in self.name for c in ['-', ' ', '.']):
+                raise InvalidArguments('Rust crate type "rlib" does not allow spaces, periods or dashes in the library name '
                                        'due to a limitation of rustc. Replace them with underscores, for example')
         # By default a static library is named libfoo.a even on Windows because
         # MSVC does not have a consistent convention for what static libraries
@@ -2082,8 +2082,8 @@ def post_init(self) -> None:
             elif self.rust_crate_type not in ['dylib', 'cdylib', 'proc-macro']:
                 raise InvalidArguments(f'Crate type "{self.rust_crate_type}" invalid for dynamic libraries; must be "dylib", "cdylib", or "proc-macro"')
             # See https://github.com/rust-lang/rust/issues/110460
-            if self.rust_crate_type != 'cdylib' and any(c in self.name for c in ['-', ' ']):
-                raise InvalidArguments('Rust crate types "dylib" and "proc-macro" do not allow spaces or dashes in the library name '
+            if self.rust_crate_type != 'cdylib' and any(c in self.name for c in ['-', ' ', '.']):
+                raise InvalidArguments('Rust crate types "dylib" and "proc-macro" do not allow spaces, periods or dashes in the library name '
                                        'due to a limitation of rustc. Replace them with underscores, for example')
 
         if not hasattr(self, 'prefix'):