Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docs navigation header point to numpy.org rather than scipy.org #292

Closed
adeak opened this issue May 24, 2020 · 4 comments
Closed

Make docs navigation header point to numpy.org rather than scipy.org #292

adeak opened this issue May 24, 2020 · 4 comments

Comments

@adeak
Copy link

adeak commented May 24, 2020

At https://numpy.org/doc/stable/ which is directly accessible from numpy.org via the top documentation link, the top navigation link says "Scipy.org", and both links do in fact lead back to scipy.org and docs.scipy.org, respectively.

I suspect this is already on your radar and will be affected by the Sphinx theme manipulations (edit: and keeping the docs.scipy.org link might be on purpose), but I couldn't find an explicit mention after searching the existing issues.

@rossbar
Copy link
Contributor

rossbar commented May 24, 2020

Nice catch - I think this is an issue with the most current 1.18 docs having been built and uploaded before the link badging change. Looking into it...

@adeak
Copy link
Author

adeak commented May 24, 2020

Perhaps fixing this and potentially renaming the "Docs" button to "All docs" could also help with #293 (comment). We'd be back at "single click takes you to numpy.org/doc".

@rossbar
Copy link
Contributor

rossbar commented May 24, 2020

At https://numpy.org/doc/stable/ which is directly accessible from numpy.org via the top documentation link, the top navigation link says "Scipy.org", and both links do in fact lead back to scipy.org and docs.scipy.org, respectively.

This should now be fixed via numpy/doc@20a1b0f for the stable docs (1.18.4). The tags should now point to numpy.org and numpy.org/doc, respectively.

Perhaps fixing this and potentially renaming the "Docs" button to "All docs" could also help with #293 (comment). We'd be back at "single click takes you to numpy.org/doc".

This is a nice suggestion - making the "Doc" tag a bit more descriptive may help. I think this would be an update to the sphinx theme rather than numpy.org website (as you noted in the comments above).

@adeak
Copy link
Author

adeak commented May 24, 2020

@rossbar very nice, thank you for the fix! I'm closing this issue because the main point is fixed. I'll copy over my button renaming suggestion to the other issue to have it in a more relevant place.

@adeak adeak closed this as completed May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants