Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: please update for jinja2 3.x #376

Closed
kloczek opened this issue Apr 10, 2022 · 6 comments
Closed

RFE: please update for jinja2 3.x #376

kloczek opened this issue Apr 10, 2022 · 6 comments
Milestone

Comments

@kloczek
Copy link

kloczek commented Apr 10, 2022

Yeah .. it would be good to update for latest jinja2 😃

install_requires=["sphinx>=1.8", 'Jinja2>=2.10,<3.1'],

@rossbar
Copy link
Contributor

rossbar commented Apr 12, 2022

Jinja 3.1 won't work with sphinx<4.0.2 and numpydoc currently supports sphinx 2 & 3, hence the Jinja2 pin. See sphinx-doc/sphinx#10291

@kloczek
Copy link
Author

kloczek commented Apr 12, 2022

Jinja 3.1 won't work with sphinx<4.0.2 and numpydoc currently supports sphinx 2 & 3, hence the Jinja2 pin. See sphinx-doc/sphinx#10291

Spjinx 2.x and 3.x are no longer mantained.
What os the point provide support for those older versions on master? 🤔
Looking on my almost 900 already packaged python modules I dont see ay module which may need support for sphinx 2.x and 3.x.
Do you know any module name which may need numpydoc support for those sphinx versions? 🤔

@jarrodmillman
Copy link
Member

See #385.

@jarrodmillman
Copy link
Member

@jarrodmillman jarrodmillman added this to the 1.3.0 milestone Apr 25, 2022
@jarrodmillman
Copy link
Member

@kloczek
Copy link
Author

kloczek commented Sep 26, 2023

Just tested 3.8.1 and indeed all is clean now.
Thank you 👍 😄

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-utils-3.8.1-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-utils-3.8.1-2.fc35.x86_64/usr/lib/
+ /usr/bin/pytest -ra -m 'not network'
============================= test session starts ==============================
platform linux -- Python 3.8.18, pytest-7.4.2, pluggy-1.3.0
rootdir: /home/tkloczko/rpmbuild/BUILD/python-utils-3.8.1
configfile: pytest.ini
plugins: asyncio-0.21.1
asyncio: mode=strict
collected 57 items

_python_utils_tests/test_aio.py ..                                       [  3%]
_python_utils_tests/test_containers.py .....                             [ 12%]
_python_utils_tests/test_decorators.py ....                              [ 19%]
_python_utils_tests/test_generators.py ....                              [ 26%]
_python_utils_tests/test_import.py ......                                [ 36%]
_python_utils_tests/test_logger.py .                                     [ 38%]
_python_utils_tests/test_python_utils.py .                               [ 40%]
_python_utils_tests/test_time.py ...........                             [ 59%]
python_utils/containers.py ....                                          [ 66%]
python_utils/converters.py ......                                        [ 77%]
python_utils/decorators.py ...                                           [ 82%]
python_utils/exceptions.py .                                             [ 84%]
python_utils/formatters.py ...                                           [ 89%]
python_utils/logger.py ..                                                [ 92%]
python_utils/time.py ....                                                [100%]

============================== 57 passed in 4.56s ==============================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants