Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safeguard: make sure this is invoked on a Windows machine #2

Closed
Ecco opened this issue Oct 6, 2019 · 1 comment · Fixed by #6
Closed

Safeguard: make sure this is invoked on a Windows machine #2

Ecco opened this issue Oct 6, 2019 · 1 comment · Fixed by #6

Comments

@Ecco
Copy link
Contributor

Ecco commented Oct 6, 2019

Since msys2 only makes sense on Windows, we could add a check to make sure we're on a Windows machine and insult warn the daydreaming user if it's not the case.
@Ecco Ecco mentioned this issue Oct 6, 2019
Closed
@Ecco
Copy link
Contributor Author

Ecco commented Oct 6, 2019

For the record, here's how the check is done in @tool-cache:

const IS_WINDOWS = process.platform === 'win32'

This was referenced Oct 6, 2019
Closed
Merged
@Ecco Ecco closed this as completed in #6 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Ecco