Replies: 2 comments
-
See my comment on nunit/nunit3-vs-adapter#529 |
Beta Was this translation helpful? Give feedback.
0 replies
-
Need to review this and decide whether to include in 4.0, postpone or close. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Following up from nunit/nunit#2867: Skipping TestCaseSource invocation for tests outside the filter is not as intensely obvious for the console runner as it is for the VS adapter, since I tend to use the console for larger fractions of tests. However, there will still be noticeable time savings in our build scripts at work.
@CharliePoole has introduced discovery-time filtering in the framework and integrated with it in the NUnitLite runner. This pattern should be easy to follow in all the other runners: nunit/nunit#2878
For @oznetmaster, this has resulted in roughly a 12x performance boost: nunit/nunit#2878 (comment).
There's a possibility that this is also going to hold up the same enhancement in the adapter, which relies on the engine in this repo: nunit/nunit3-vs-adapter#529. Is this something we'd be willing to ship in the next console release without waiting for the framework's next release?
Beta Was this translation helpful? Give feedback.
All reactions